All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andi Kleen <ak@suse.de>
Cc: Xen-devel <xen-devel@lists.xensource.com>,
	john stultz <johnstul@us.ibm.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Chris Wright <chrisw@sous-sol.org>,
	virtualization@lists.osdl.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [patch 13/28]xen: Implement xen_sched_clock
Date: Thu, 10 May 2007 17:06:56 -0700	[thread overview]
Message-ID: <20070511001201.487691000@goop.org> (raw)
In-Reply-To: 20070511000643.025196000@goop.org

[-- Attachment #1: xen-sched-clock.patch --]
[-- Type: text/plain, Size: 2936 bytes --]

Implement xen_sched_clock, which returns the number of ns the current
vcpu has been actually in an unstolen state (ie, running or blocked,
vs runnable-but-not-running, or offline) since boot.

Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
Acked-by: Chris Wright <chrisw@sous-sol.org>
Cc: john stultz <johnstul@us.ibm.com>

---
 arch/i386/xen/enlighten.c |    2 +-
 arch/i386/xen/time.c      |   22 +++++++++++++++++++++-
 arch/i386/xen/xen-ops.h   |    3 +--
 3 files changed, 23 insertions(+), 4 deletions(-)

===================================================================
--- a/arch/i386/xen/enlighten.c
+++ b/arch/i386/xen/enlighten.c
@@ -676,7 +676,7 @@ static const struct paravirt_ops xen_par
 	.set_wallclock = xen_set_wallclock,
 	.get_wallclock = xen_get_wallclock,
 	.get_cpu_khz = xen_cpu_khz,
-	.sched_clock = xen_clocksource_read,
+	.sched_clock = xen_sched_clock,
 
 #ifdef CONFIG_X86_LOCAL_APIC
 	.apic_write = paravirt_nop,
===================================================================
--- a/arch/i386/xen/time.c
+++ b/arch/i386/xen/time.c
@@ -16,6 +16,8 @@
 #define XEN_SHIFT 22
 #define TIMER_SLOP	100000	/* Xen may fire a timer up to this many ns early */
 #define NS_PER_TICK	(1000000000ll / HZ)
+
+static cycle_t xen_clocksource_read(void);
 
 /* These are perodically updated in shared_info, and then copied here. */
 struct shadow_time_info {
@@ -118,6 +120,24 @@ static void do_stolen_accounting(void)
 	account_steal_time(idle_task(smp_processor_id()), ticks);
 }
 
+/*
+ * Xen sched_clock implementation.  Returns the number of unstolen
+ * nanoseconds, which is nanoseconds the VCPU spent in RUNNING+BLOCKED
+ * states.
+ */
+unsigned long long xen_sched_clock(void)
+{
+	struct vcpu_runstate_info state;
+	cycle_t now = xen_clocksource_read();
+
+	get_runstate_snapshot(&state);
+
+	WARN_ON(state.state != RUNSTATE_running);
+
+	return state.time[RUNSTATE_blocked] +
+		state.time[RUNSTATE_running] +
+		(now - state.state_entry_time);
+}
 
 
 /* Get the CPU speed from Xen */
@@ -209,7 +229,7 @@ static u64 get_nsec_offset(struct shadow
 	return scale_delta(delta, shadow->tsc_to_nsec_mul, shadow->tsc_shift);
 }
 
-cycle_t xen_clocksource_read(void)
+static cycle_t xen_clocksource_read(void)
 {
 	struct shadow_time_info *shadow = &get_cpu_var(shadow_time);
 	cycle_t ret;
===================================================================
--- a/arch/i386/xen/xen-ops.h
+++ b/arch/i386/xen/xen-ops.h
@@ -2,7 +2,6 @@
 #define XEN_OPS_H
 
 #include <linux/init.h>
-#include <linux/clocksource.h>
 
 DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu);
 DECLARE_PER_CPU(unsigned long, xen_cr3);
@@ -18,7 +17,7 @@ void __init xen_time_init(void);
 void __init xen_time_init(void);
 unsigned long xen_get_wallclock(void);
 int xen_set_wallclock(unsigned long time);
-cycle_t xen_clocksource_read(void);
+unsigned long long xen_sched_clock(void);
 
 void xen_mark_init_mm_pinned(void);
 

-- 

WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andi Kleen <ak@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	virtualization@lists.osdl.org,
	lkml <linux-kernel@vger.kernel.org>,
	Chris Wright <chrisw@sous-sol.org>,
	Xen-devel <xen-devel@lists.xensource.com>,
	john stultz <johnstul@us.ibm.com>
Subject: [patch 13/28]xen: Implement xen_sched_clock
Date: Thu, 10 May 2007 17:06:56 -0700	[thread overview]
Message-ID: <20070511001201.487691000@goop.org> (raw)
In-Reply-To: 20070511000643.025196000@goop.org

[-- Attachment #1: xen-sched-clock.patch --]
[-- Type: text/plain, Size: 2937 bytes --]

Implement xen_sched_clock, which returns the number of ns the current
vcpu has been actually in an unstolen state (ie, running or blocked,
vs runnable-but-not-running, or offline) since boot.

Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
Acked-by: Chris Wright <chrisw@sous-sol.org>
Cc: john stultz <johnstul@us.ibm.com>

---
 arch/i386/xen/enlighten.c |    2 +-
 arch/i386/xen/time.c      |   22 +++++++++++++++++++++-
 arch/i386/xen/xen-ops.h   |    3 +--
 3 files changed, 23 insertions(+), 4 deletions(-)

===================================================================
--- a/arch/i386/xen/enlighten.c
+++ b/arch/i386/xen/enlighten.c
@@ -676,7 +676,7 @@ static const struct paravirt_ops xen_par
 	.set_wallclock = xen_set_wallclock,
 	.get_wallclock = xen_get_wallclock,
 	.get_cpu_khz = xen_cpu_khz,
-	.sched_clock = xen_clocksource_read,
+	.sched_clock = xen_sched_clock,
 
 #ifdef CONFIG_X86_LOCAL_APIC
 	.apic_write = paravirt_nop,
===================================================================
--- a/arch/i386/xen/time.c
+++ b/arch/i386/xen/time.c
@@ -16,6 +16,8 @@
 #define XEN_SHIFT 22
 #define TIMER_SLOP	100000	/* Xen may fire a timer up to this many ns early */
 #define NS_PER_TICK	(1000000000ll / HZ)
+
+static cycle_t xen_clocksource_read(void);
 
 /* These are perodically updated in shared_info, and then copied here. */
 struct shadow_time_info {
@@ -118,6 +120,24 @@ static void do_stolen_accounting(void)
 	account_steal_time(idle_task(smp_processor_id()), ticks);
 }
 
+/*
+ * Xen sched_clock implementation.  Returns the number of unstolen
+ * nanoseconds, which is nanoseconds the VCPU spent in RUNNING+BLOCKED
+ * states.
+ */
+unsigned long long xen_sched_clock(void)
+{
+	struct vcpu_runstate_info state;
+	cycle_t now = xen_clocksource_read();
+
+	get_runstate_snapshot(&state);
+
+	WARN_ON(state.state != RUNSTATE_running);
+
+	return state.time[RUNSTATE_blocked] +
+		state.time[RUNSTATE_running] +
+		(now - state.state_entry_time);
+}
 
 
 /* Get the CPU speed from Xen */
@@ -209,7 +229,7 @@ static u64 get_nsec_offset(struct shadow
 	return scale_delta(delta, shadow->tsc_to_nsec_mul, shadow->tsc_shift);
 }
 
-cycle_t xen_clocksource_read(void)
+static cycle_t xen_clocksource_read(void)
 {
 	struct shadow_time_info *shadow = &get_cpu_var(shadow_time);
 	cycle_t ret;
===================================================================
--- a/arch/i386/xen/xen-ops.h
+++ b/arch/i386/xen/xen-ops.h
@@ -2,7 +2,6 @@
 #define XEN_OPS_H
 
 #include <linux/init.h>
-#include <linux/clocksource.h>
 
 DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu);
 DECLARE_PER_CPU(unsigned long, xen_cr3);
@@ -18,7 +17,7 @@ void __init xen_time_init(void);
 void __init xen_time_init(void);
 unsigned long xen_get_wallclock(void);
 int xen_set_wallclock(unsigned long time);
-cycle_t xen_clocksource_read(void);
+unsigned long long xen_sched_clock(void);
 
 void xen_mark_init_mm_pinned(void);
 

-- 


  parent reply	other threads:[~2007-05-11  0:06 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-11  0:06 [patch 00/28]xen: Xen implementation for paravirt_ops Jeremy Fitzhardinge
2007-05-11  0:06 ` Jeremy Fitzhardinge
2007-05-11  0:06 ` [patch 01/28]xen: Allocate and free vmalloc areas Jeremy Fitzhardinge
2007-05-11  0:06   ` Jeremy Fitzhardinge
2007-05-11  0:06 ` [patch 02/28]xen: Add nosegneg capability to the vsyscall page notes Jeremy Fitzhardinge
2007-05-11  0:06   ` Jeremy Fitzhardinge
2007-05-11 20:07   ` Roland McGrath
2007-05-11 20:25     ` Jeremy Fitzhardinge
2007-05-11  0:06 ` [patch 03/28]xen: Add Xen interface header files Jeremy Fitzhardinge
2007-05-11  0:06   ` Jeremy Fitzhardinge
2007-05-11  0:06 ` [patch 04/28]xen: Core Xen implementation Jeremy Fitzhardinge
2007-05-11  0:06   ` Jeremy Fitzhardinge
2007-05-11  0:06 ` [patch 05/28]xen: Xen virtual mmu Jeremy Fitzhardinge
2007-05-11  0:06   ` Jeremy Fitzhardinge
2007-05-11  0:06 ` [patch 06/28]xen: xen event channels Jeremy Fitzhardinge
2007-05-11  0:06   ` Jeremy Fitzhardinge
2007-05-11  0:06 ` [patch 07/28]xen: xen time implementation Jeremy Fitzhardinge
2007-05-11  0:06   ` Jeremy Fitzhardinge
2007-05-11  0:06 ` [patch 08/28]xen: xen configuration Jeremy Fitzhardinge
2007-05-11  0:06   ` Jeremy Fitzhardinge
2007-05-11  0:06 ` [patch 09/28]xen: Complete pagetable pinning for Xen Jeremy Fitzhardinge
2007-05-11  0:06   ` Jeremy Fitzhardinge
2007-05-11  0:06 ` [patch 10/28]xen: ignore RW mapping of RO pages in pagetable_init Jeremy Fitzhardinge
2007-05-11  0:06   ` Jeremy Fitzhardinge
2007-05-11  0:06 ` [patch 11/28]xen: fix multicall batching Jeremy Fitzhardinge
2007-05-11  0:06   ` Jeremy Fitzhardinge
2007-05-11  0:06 ` [patch 12/28]xen: Account for time stolen by Xen Jeremy Fitzhardinge
2007-05-11  0:06   ` Jeremy Fitzhardinge
2007-05-11  0:06 ` Jeremy Fitzhardinge [this message]
2007-05-11  0:06   ` [patch 13/28]xen: Implement xen_sched_clock Jeremy Fitzhardinge
2007-05-11  0:06 ` [patch 14/28]xen: Xen SMP guest support Jeremy Fitzhardinge
2007-05-11  0:06   ` Jeremy Fitzhardinge
2007-05-11  0:06 ` [patch 15/28]xen: Add support for preemption Jeremy Fitzhardinge
2007-05-11  0:06   ` Jeremy Fitzhardinge
2007-05-11  0:06 ` [patch 16/28]xen: lazy-mmu operations Jeremy Fitzhardinge
2007-05-11  0:06   ` Jeremy Fitzhardinge
2007-05-11  0:07 ` [patch 17/28]xen: deal with negative stolen time Jeremy Fitzhardinge
2007-05-11  0:07   ` Jeremy Fitzhardinge
2007-05-11  0:07 ` [patch 18/28]xen: Use the hvc console infrastructure for Xen console Jeremy Fitzhardinge
2007-05-11  0:07   ` Jeremy Fitzhardinge
2007-05-11  0:07 ` [patch 19/28]xen: Add early printk support via hvc console Jeremy Fitzhardinge
2007-05-11  0:07   ` Jeremy Fitzhardinge
2007-05-12 19:08   ` [Xen-devel] " Bastian Blank
2007-05-12 19:57     ` Jeremy Fitzhardinge
2007-05-12 19:57       ` [Xen-devel] " Jeremy Fitzhardinge
2007-05-11  0:07 ` [patch 20/28]xen: Add Xen grant table support Jeremy Fitzhardinge
2007-05-11  0:07   ` Jeremy Fitzhardinge
2007-05-11  0:07 ` [patch 21/28]xen: Add the Xenbus sysfs and virtual device hotplug driver Jeremy Fitzhardinge
2007-05-11  0:07   ` Jeremy Fitzhardinge
2007-05-11  0:07 ` [patch 22/28]xen: Add Xen virtual block device driver Jeremy Fitzhardinge
2007-05-11  0:07   ` Jeremy Fitzhardinge
2007-05-11  0:07 ` [patch 23/28]xen: rename xen netif_ structures to xen_netif_ Jeremy Fitzhardinge
2007-05-11  0:07   ` Jeremy Fitzhardinge
2007-05-11  0:07 ` [patch 24/28]xen: Add the Xen virtual network device driver Jeremy Fitzhardinge
2007-05-11  0:07   ` Jeremy Fitzhardinge
2007-05-11  0:07 ` [patch 25/28]xen: Xen machine operations Jeremy Fitzhardinge
2007-05-11  0:07   ` Jeremy Fitzhardinge
2007-05-11  0:07 ` [patch 26/28]xen: handle external requests for shutdown, reboot and sysrq Jeremy Fitzhardinge
2007-05-11  0:07   ` Jeremy Fitzhardinge
2007-05-11  0:07 ` [patch 27/28]xen: Place vcpu_info structure into per-cpu memory, if possible Jeremy Fitzhardinge
2007-05-11  0:07   ` Jeremy Fitzhardinge
2007-05-11  0:07 ` [patch 28/28]xen: Attempt to patch inline versions of common operations Jeremy Fitzhardinge
2007-05-11  0:07   ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070511001201.487691000@goop.org \
    --to=jeremy@goop.org \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=chrisw@sous-sol.org \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.osdl.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.