From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Gautham R Shenoy <ego@in.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@tv-sign.ru>, Pavel Machek <pavel@ucw.cz>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: [PATCH 7/7] Freezer: Move frozen_process to kernel/power/process.c
Date: Fri, 11 May 2007 00:44:23 +0200 [thread overview]
Message-ID: <200705110044.23934.rjw@sisk.pl> (raw)
In-Reply-To: <200705110035.32229.rjw@sisk.pl>
From: Gautham R Shenoy <ego@in.ibm.com>
Other than refrigerator, no one else calls frozen_process(). So move it
from include/linux/freezer.h to kernel/power/process.c.
Also, since a task can be marked as frozen by itself, we don't need to pass
the (struct task_struct *p) parameter to frozen_process().
Signed-off-by: Gautham R Shenoy <ego@in.ibm.com>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
include/linux/freezer.h | 13 -------------
kernel/power/process.c | 14 +++++++++++++-
2 files changed, 13 insertions(+), 14 deletions(-)
Index: linux-2.6/include/linux/freezer.h
===================================================================
--- linux-2.6.orig/include/linux/freezer.h 2007-05-10 21:44:47.000000000 +0200
+++ linux-2.6/include/linux/freezer.h 2007-05-10 21:44:50.000000000 +0200
@@ -58,18 +58,6 @@ static inline int thaw_process(struct ta
return 0;
}
-/*
- * freezing is complete, mark process as frozen
- */
-static inline void frozen_process(struct task_struct *p)
-{
- if (!unlikely(p->flags & PF_NOFREEZE)) {
- p->flags |= PF_FROZEN;
- wmb();
- }
- clear_tsk_thread_flag(p, TIF_FREEZE);
-}
-
extern void refrigerator(void);
extern int freeze_processes(void);
extern void thaw_processes(void);
@@ -132,7 +120,6 @@ static inline int frozen(struct task_str
static inline int freezing(struct task_struct *p) { return 0; }
static inline void freeze(struct task_struct *p) { BUG(); }
static inline int thaw_process(struct task_struct *p) { return 1; }
-static inline void frozen_process(struct task_struct *p) { BUG(); }
static inline void refrigerator(void) {}
static inline int freeze_processes(void) { BUG(); return 0; }
Index: linux-2.6/kernel/power/process.c
===================================================================
--- linux-2.6.orig/kernel/power/process.c 2007-05-10 21:44:40.000000000 +0200
+++ linux-2.6/kernel/power/process.c 2007-05-10 21:44:50.000000000 +0200
@@ -32,6 +32,18 @@ static inline int freezeable(struct task
return 1;
}
+/*
+ * freezing is complete, mark current process as frozen
+ */
+static inline void frozen_process(void)
+{
+ if (!unlikely(current->flags & PF_NOFREEZE)) {
+ current->flags |= PF_FROZEN;
+ wmb();
+ }
+ clear_tsk_thread_flag(current, TIF_FREEZE);
+}
+
/* Refrigerator is place where frozen processes are stored :-). */
void refrigerator(void)
{
@@ -41,7 +53,7 @@ void refrigerator(void)
task_lock(current);
if (freezing(current)) {
- frozen_process(current);
+ frozen_process();
task_unlock(current);
} else {
task_unlock(current);
prev parent reply other threads:[~2007-05-11 9:08 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 22:35 [PATCH 0/7] Freezer bugfixes Rafael J. Wysocki
2007-05-10 22:36 ` [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way Rafael J. Wysocki
2007-05-11 19:39 ` Andrew Morton
2007-05-11 20:21 ` Oleg Nesterov
2007-05-11 20:40 ` Rafael J. Wysocki
2007-05-11 22:56 ` Linus Torvalds
2007-05-11 23:20 ` Oleg Nesterov
2007-05-11 23:32 ` Linus Torvalds
2007-05-11 23:48 ` Oleg Nesterov
2007-05-12 0:05 ` Oleg Nesterov
2007-05-12 0:08 ` Linus Torvalds
2007-05-12 0:40 ` Oleg Nesterov
2007-05-12 1:01 ` Oleg Nesterov
2007-05-12 1:24 ` Linus Torvalds
2007-05-12 9:01 ` Rafael J. Wysocki
2007-05-12 10:45 ` Rafael J. Wysocki
2007-05-12 14:18 ` Oleg Nesterov
2007-05-12 16:35 ` Rafael J. Wysocki
2007-05-12 16:58 ` Oleg Nesterov
2007-05-12 17:16 ` Rafael J. Wysocki
2007-05-12 17:43 ` Oleg Nesterov
2007-05-12 1:11 ` Rafael J. Wysocki
2007-05-11 23:22 ` Rafael J. Wysocki
2007-05-11 23:25 ` Andrew Morton
2007-05-12 0:16 ` Rafael J. Wysocki
2007-05-11 23:29 ` Linus Torvalds
2007-05-12 0:01 ` Rafael J. Wysocki
2007-05-12 8:16 ` Gautham R Shenoy
2007-05-12 9:27 ` Rafael J. Wysocki
2007-05-12 10:13 ` Gautham R Shenoy
2007-05-12 10:41 ` Rafael J. Wysocki
2007-05-12 10:52 ` Gautham R Shenoy
2007-05-12 11:34 ` Rafael J. Wysocki
2007-05-12 14:25 ` Oleg Nesterov
2007-05-12 14:59 ` migrate_dead_tasks() vs sleep-after-exit_notify() problems? Oleg Nesterov
2007-05-10 22:37 ` [PATCH 2/7] Freezer: Close potential race between refrigerator and thaw_tasks Rafael J. Wysocki
2007-05-10 22:38 ` [PATCH 3/7] Freezer: Fix vfork problem Rafael J. Wysocki
2007-05-10 22:39 ` [PATCH 4/7] Freezer: Take kernel_execve into consideration Rafael J. Wysocki
2007-05-10 22:41 ` [PATCH 5/7] Freezer: Fix kthread_create vs freezer theoretical race Rafael J. Wysocki
2007-05-10 22:43 ` [PATCH 6/7] Freezer: Fix PF_NOFREEZE vs freezeable race Rafael J. Wysocki
2007-05-10 22:44 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705110044.23934.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=ego@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=pavel@ucw.cz \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.