From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Olof Johansson <olof@lixom.net>,
paulus@samba.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] pasemi: electra IDE/pata_platform glue
Date: Sun, 13 May 2007 02:48:22 +0200 [thread overview]
Message-ID: <200705130248.22844.arnd@arndb.de> (raw)
In-Reply-To: <20070513005830.38ba8e3b@the-village.bc.nu>
On Sunday 13 May 2007, Alan Cox wrote:
> > Why not provide a proper pata_of.c driver based on ata_generic? That
> > will help the next person that has a builtin ata controller and wants
> > to get it running as an of_device.
>
> Easier to use pata_platform I would think ? Just create the OF device and
> bind it to pata_platform.
Not sure I understand what you mean. pata_platform expects a platform_device,
which cannot be cast from an of_device.
Actually, it might be possible to merge the common parts of pata_platform,
ata_generic and ata_of into one module, and have one driver for each
of the three bus_types on top of it. Currently, the only difference between
ata_generic and pata_platform is the ->set_mode function, which can
probably be made generic (controlled by a flag in the ata_port).
Olof, have you looked at which of the two ->set_mode functions is more
appropriate for electra? I would guess that you actually want to use
the ata_generic one.
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Olof Johansson <olof@lixom.net>,
linux-ide@vger.kernel.org, paulus@samba.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] pasemi: electra IDE/pata_platform glue
Date: Sun, 13 May 2007 02:48:22 +0200 [thread overview]
Message-ID: <200705130248.22844.arnd@arndb.de> (raw)
In-Reply-To: <20070513005830.38ba8e3b@the-village.bc.nu>
On Sunday 13 May 2007, Alan Cox wrote:
> > Why not provide a proper pata_of.c driver based on ata_generic? That
> > will help the next person that has a builtin ata controller and wants
> > to get it running as an of_device.
>
> Easier to use pata_platform I would think ? Just create the OF device and
> bind it to pata_platform.
Not sure I understand what you mean. pata_platform expects a platform_device,
which cannot be cast from an of_device.
Actually, it might be possible to merge the common parts of pata_platform,
ata_generic and ata_of into one module, and have one driver for each
of the three bus_types on top of it. Currently, the only difference between
ata_generic and pata_platform is the ->set_mode function, which can
probably be made generic (controlled by a flag in the ata_port).
Olof, have you looked at which of the two ->set_mode functions is more
appropriate for electra? I would guess that you actually want to use
the ata_generic one.
Arnd <><
next prev parent reply other threads:[~2007-05-13 0:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-12 14:50 [PATCH] pasemi: electra IDE/pata_platform glue Olof Johansson
2007-05-12 23:11 ` Arnd Bergmann
2007-05-12 23:11 ` Arnd Bergmann
2007-05-12 23:58 ` Alan Cox
2007-05-12 23:58 ` Alan Cox
2007-05-13 0:48 ` Arnd Bergmann [this message]
2007-05-13 0:48 ` Arnd Bergmann
2007-05-13 2:20 ` Benjamin Herrenschmidt
2007-05-13 2:20 ` Benjamin Herrenschmidt
2007-05-13 6:19 ` Olof Johansson
2007-05-13 6:19 ` Olof Johansson
2007-05-13 8:01 ` Benjamin Herrenschmidt
2007-05-13 8:01 ` Benjamin Herrenschmidt
2007-05-13 11:17 ` Segher Boessenkool
2007-05-13 11:17 ` Segher Boessenkool
2007-05-13 13:39 ` Alan Cox
2007-05-13 13:39 ` Alan Cox
2007-05-13 21:18 ` Olof Johansson
2007-05-13 21:18 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705130248.22844.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.