From: Stefan Seyfried <seife@suse.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Coywolf Qi Hunt <coywolf@gmail.com>, Len Brown <lenb@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alexey Starikovskiy <alexey_y_starikovskiy@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH] swsusp: Use platform mode by default
Date: Mon, 14 May 2007 09:50:45 +0200 [thread overview]
Message-ID: <20070514075045.GA10238@suse.de> (raw)
In-Reply-To: <alpine.LFD.0.98.0705111550540.3986@woody.linux-foundation.org>
On Fri, May 11, 2007 at 03:51:38PM -0700, Linus Torvalds wrote:
>
>
> On Fri, 11 May 2007, Rafael J. Wysocki wrote:
> >
> > Just to clarify, the change in question isn't new. It was introduced by the
> > commit 9185cfa92507d07ac787bc73d06c42222eec7239 before 2.6.20, at Seife's
> > request and with Pavel's acceptance.
>
> Ok, if it's that old, we migt as leave it in. Clearly there weren't many
> regressions, and this isn't a case of other monsters lurking behind a lack
> of testers.
I pushed for this since on ACPI machines, "platform" is the right thing to do,
and i still think it will only break on machines that have a broken ACPI BIOS.
(Are there machines with broken ACPI BIOS around? ;-)
Your additional "fall back to shutdown if !(ops)"-fix looks very sane,
however, and is definitely a good idea.
--
Stefan Seyfried
QA / R&D Team Mobile Devices | "Any ideas, John?"
SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out."
This footer brought to you by insane German lawmakers:
SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Seyfried <seife@suse.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Coywolf Qi Hunt <coywolf@gmail.com>, Len Brown <lenb@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alexey Starikovskiy <alexey_y_starikovskiy@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH] swsusp: Use platform mode by default
Date: Mon, 14 May 2007 09:50:45 +0200 [thread overview]
Message-ID: <20070514075045.GA10238@suse.de> (raw)
In-Reply-To: <alpine.LFD.0.98.0705111550540.3986@woody.linux-foundation.org>
On Fri, May 11, 2007 at 03:51:38PM -0700, Linus Torvalds wrote:
>
>
> On Fri, 11 May 2007, Rafael J. Wysocki wrote:
> >
> > Just to clarify, the change in question isn't new. It was introduced by the
> > commit 9185cfa92507d07ac787bc73d06c42222eec7239 before 2.6.20, at Seife's
> > request and with Pavel's acceptance.
>
> Ok, if it's that old, we migt as leave it in. Clearly there weren't many
> regressions, and this isn't a case of other monsters lurking behind a lack
> of testers.
I pushed for this since on ACPI machines, "platform" is the right thing to do,
and i still think it will only break on machines that have a broken ACPI BIOS.
(Are there machines with broken ACPI BIOS around? ;-)
Your additional "fall back to shutdown if !(ops)"-fix looks very sane,
however, and is definitely a good idea.
--
Stefan Seyfried
QA / R&D Team Mobile Devices | "Any ideas, John?"
SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out."
This footer brought to you by insane German lawmakers:
SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
next prev parent reply other threads:[~2007-05-14 7:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-01 12:23 [PATCH] swsusp: Use platform mode by default Rafael J. Wysocki
2006-11-01 12:45 ` Stefan Seyfried
2006-11-01 12:45 ` Stefan Seyfried
2006-11-01 13:21 ` Pavel Machek
2006-11-02 3:40 ` Len Brown
2007-05-11 8:36 ` Coywolf Qi Hunt
2007-05-11 9:21 ` Rafael J. Wysocki
2007-05-11 16:30 ` Linus Torvalds
2007-05-11 20:08 ` Rafael J. Wysocki
2007-05-11 22:51 ` Linus Torvalds
2007-05-11 23:23 ` Pavel Machek
2007-05-12 3:50 ` Len Brown
2007-05-14 7:50 ` Stefan Seyfried [this message]
2007-05-14 7:50 ` Stefan Seyfried
2007-10-17 2:35 ` Qi Yong
2007-10-17 2:46 ` Linus Torvalds
2007-05-14 0:36 ` Bill Davidsen
2007-10-17 2:46 ` Qi Yong
2007-10-17 3:44 ` Qi Yong
2007-10-17 17:32 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070514075045.GA10238@suse.de \
--to=seife@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alexey_y_starikovskiy@linux.intel.com \
--cc=coywolf@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.