From: Theodore Tso <tytso@mit.edu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Fengguang Wu <fengguang.wu@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Rik van Riel <riel@redhat.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] resolve duplicate flag no for PG_lazyfree
Date: Mon, 14 May 2007 14:06:19 -0400 [thread overview]
Message-ID: <20070514180618.GB9399@thunk.org> (raw)
In-Reply-To: <20070513224630.3cd0cb54.akpm@linux-foundation.org>
On Sun, May 13, 2007 at 10:46:30PM -0700, Andrew Morton wrote:
> otoh, the intersection between pages which are PageBooked() and pages which
> are PageLazyFree() should be zreo, so it'd be good to actually formalise
> this reuse within the ext4 patches.
>
> otoh2, PageLazyFree() could have reused PG_owner_priv_1.
>
> Rik, Ted: any thoughts? We do need to scrimp on page flags: when we
> finally run out, we're screwed.
It makes sense to me. PG_lazyfree is currently only in -mm, right? I
don't see it in my git tree. It would probably would be a good idea
to make sure that we check to add some sanity checking code if it
isn't there already that PG_lazyfree isn't already set when try to set
PG_lazyfree (just in case there is a bug in the future which causes
the should-never-happen case of trying lazy free a PageBooked page).
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: Theodore Tso <tytso@mit.edu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Fengguang Wu <fengguang.wu@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Rik van Riel <riel@redhat.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] resolve duplicate flag no for PG_lazyfree
Date: Mon, 14 May 2007 14:06:19 -0400 [thread overview]
Message-ID: <20070514180618.GB9399@thunk.org> (raw)
In-Reply-To: <20070513224630.3cd0cb54.akpm@linux-foundation.org>
On Sun, May 13, 2007 at 10:46:30PM -0700, Andrew Morton wrote:
> otoh, the intersection between pages which are PageBooked() and pages which
> are PageLazyFree() should be zreo, so it'd be good to actually formalise
> this reuse within the ext4 patches.
>
> otoh2, PageLazyFree() could have reused PG_owner_priv_1.
>
> Rik, Ted: any thoughts? We do need to scrimp on page flags: when we
> finally run out, we're screwed.
It makes sense to me. PG_lazyfree is currently only in -mm, right? I
don't see it in my git tree. It would probably would be a good idea
to make sure that we check to add some sanity checking code if it
isn't there already that PG_lazyfree isn't already set when try to set
PG_lazyfree (just in case there is a bug in the future which causes
the should-never-happen case of trying lazy free a PageBooked page).
- Ted
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-05-14 18:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-14 2:37 [PATCH] resolve duplicate flag no for PG_lazyfree Fengguang Wu
2007-05-14 2:37 ` Fengguang Wu
2007-05-14 5:46 ` Andrew Morton
2007-05-14 5:46 ` Andrew Morton
2007-05-14 7:55 ` Fengguang Wu
2007-05-14 7:55 ` Fengguang Wu
2007-05-14 7:55 ` Fengguang Wu
2007-05-14 18:06 ` Theodore Tso [this message]
2007-05-14 18:06 ` Theodore Tso
2007-05-14 20:46 ` Andrew Morton
2007-05-14 20:46 ` Andrew Morton
2007-05-16 0:28 ` Nick Piggin
2007-05-16 0:28 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070514180618.GB9399@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.