From: Stephen Hemminger <shemminger@linux-foundation.org>
To: stable@kernel.org
Cc: netdev@vger.kernel.org
Subject: [PATCH 2/6] skge: default WOL should be magic only
Date: Tue, 15 May 2007 15:08:23 -0700 [thread overview]
Message-ID: <20070515220903.522640228@linux-foundation.org> (raw)
In-Reply-To: 20070515220821.676720721@linux-foundation.org
[-- Attachment #1: skge-wol-magic --]
[-- Type: text/plain, Size: 866 bytes --]
By default, the skge driver now enables wake on magic and wake on PHY.
This is a bad default (bug), wake on PHY means machine will never shutdown
if connected to a switch.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>a
---
drivers/net/skge.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- linux-2.6.21.y.orig/drivers/net/skge.c 2007-05-10 13:26:26.000000000 -0700
+++ linux-2.6.21.y/drivers/net/skge.c 2007-05-10 13:26:31.000000000 -0700
@@ -3586,7 +3586,9 @@ static struct net_device *skge_devinit(s
skge->duplex = -1;
skge->speed = -1;
skge->advertising = skge_supported_modes(hw);
- skge->wol = pci_wake_enabled(hw->pdev) ? wol_supported(hw) : 0;
+
+ if (pci_wake_enabled(hw->pdev))
+ skge->wol = wol_supported(hw) & WAKE_MAGIC;
hw->dev[port] = dev;
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-05-15 22:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 22:08 [PATCH 0/6] skge/sky2 patches for 2.6.21.2 Stephen Hemminger
2007-05-15 22:08 ` [PATCH 1/6] skge: allow WOL except for known broken chips Stephen Hemminger
2007-05-15 22:08 ` Stephen Hemminger [this message]
2007-05-15 22:08 ` [PATCH 3/6] sky2: allow 88E8056 Stephen Hemminger
2007-05-17 1:23 ` [stable] " Chris Wright
2007-05-15 22:08 ` [PATCH 4/6] sky2: 88e8071 support not ready Stephen Hemminger
2007-05-17 1:24 ` [stable] " Chris Wright
2007-05-15 22:08 ` [PATCH 5/6] skge: crash on shutdown/suspend Stephen Hemminger
2007-05-15 22:08 ` [PATCH 6/6] sky2: fix oops on shutdown Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070515220903.522640228@linux-foundation.org \
--to=shemminger@linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.