All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: stable@kernel.org
Cc: netdev@vger.kernel.org
Subject: [PATCH 5/6] skge: crash on shutdown/suspend
Date: Tue, 15 May 2007 15:08:26 -0700	[thread overview]
Message-ID: <20070515220903.789054831@linux-foundation.org> (raw)
In-Reply-To: 20070515220821.676720721@linux-foundation.org

[-- Attachment #1: skge-shutdown.patch --]
[-- Type: text/plain, Size: 1237 bytes --]

If device fails during module startup for some reason (like unsupported chip
version) then driver would crash dereferencing a null pointer, on shutdown
or suspend/resume.

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>

---
 drivers/net/skge.c |    9 +++++++++
 1 file changed, 9 insertions(+)

--- linux-2.6.21.y.orig/drivers/net/skge.c	2007-05-15 09:06:30.000000000 -0700
+++ linux-2.6.21.y/drivers/net/skge.c	2007-05-15 09:07:20.000000000 -0700
@@ -3794,6 +3794,9 @@ static int skge_suspend(struct pci_dev *
 	struct skge_hw *hw  = pci_get_drvdata(pdev);
 	int i, err, wol = 0;
 
+	if (!hw)
+		return 0;
+
 	err = pci_save_state(pdev);
 	if (err)
 		return err;
@@ -3822,6 +3825,9 @@ static int skge_resume(struct pci_dev *p
 	struct skge_hw *hw  = pci_get_drvdata(pdev);
 	int i, err;
 
+	if (!hw)
+		return 0;
+
 	err = pci_set_power_state(pdev, PCI_D0);
 	if (err)
 		goto out;
@@ -3860,6 +3866,9 @@ static void skge_shutdown(struct pci_dev
 	struct skge_hw *hw  = pci_get_drvdata(pdev);
 	int i, wol = 0;
 
+	if (!hw)
+		return;
+
 	for (i = 0; i < hw->ports; i++) {
 		struct net_device *dev = hw->dev[i];
 		struct skge_port *skge = netdev_priv(dev);

--
Stephen Hemminger <shemminger@linux-foundation.org>


  parent reply	other threads:[~2007-05-15 22:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-15 22:08 [PATCH 0/6] skge/sky2 patches for 2.6.21.2 Stephen Hemminger
2007-05-15 22:08 ` [PATCH 1/6] skge: allow WOL except for known broken chips Stephen Hemminger
2007-05-15 22:08 ` [PATCH 2/6] skge: default WOL should be magic only Stephen Hemminger
2007-05-15 22:08 ` [PATCH 3/6] sky2: allow 88E8056 Stephen Hemminger
2007-05-17  1:23   ` [stable] " Chris Wright
2007-05-15 22:08 ` [PATCH 4/6] sky2: 88e8071 support not ready Stephen Hemminger
2007-05-17  1:24   ` [stable] " Chris Wright
2007-05-15 22:08 ` Stephen Hemminger [this message]
2007-05-15 22:08 ` [PATCH 6/6] sky2: fix oops on shutdown Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070515220903.789054831@linux-foundation.org \
    --to=shemminger@linux-foundation.org \
    --cc=netdev@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.