From: David Miller <davem@davemloft.net>
To: adaplas@gmail.com
Cc: hch@infradead.org, akpm@osdl.org,
linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/10] [HEADS UP] fbdev: Move arch-specific bits to their respective subdirectories
Date: Thu, 17 May 2007 13:30:03 -0700 (PDT) [thread overview]
Message-ID: <20070517.133003.63739733.davem@davemloft.net> (raw)
In-Reply-To: <1179399082.4586.10.camel@daplas>
From: "Antonino A. Daplas" <adaplas@gmail.com>
Date: Thu, 17 May 2007 18:51:22 +0800
> On Thu, 2007-05-17 at 10:49 +0100, Christoph Hellwig wrote:
> > On Thu, May 17, 2007 at 05:33:48AM +0800, Antonino A. Daplas wrote:
> > > -#if defined(__sparc__) && !defined(__sparc_v9__)
> > > - /* Should never get here, all fb drivers should have their own
> > > - mmap routines */
> > > - return -EINVAL;
> > > -#else
> > > - /* !sparc32... */
> > > + if (fb_mmap_required())
> > > + return -EINVAL;
> > > +
> >
> > I don't like this bit.
>
> Me too, actually. I did it this way because I don't want to deviate from
> the old code too much. Since all sparc32 drivers are either linked to
> sbuslib.c or has their own fb_mmap method, the above test is redundant.
> I'll leave the decision to remove the above test to David Miller.
Feel free to remove it.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: adaplas@gmail.com
Cc: hch@infradead.org, akpm@osdl.org,
linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/10] [HEADS UP] fbdev: Move arch-specific bits to their respective subdirectories
Date: Thu, 17 May 2007 13:30:03 -0700 (PDT) [thread overview]
Message-ID: <20070517.133003.63739733.davem@davemloft.net> (raw)
In-Reply-To: <1179399082.4586.10.camel@daplas>
From: "Antonino A. Daplas" <adaplas@gmail.com>
Date: Thu, 17 May 2007 18:51:22 +0800
> On Thu, 2007-05-17 at 10:49 +0100, Christoph Hellwig wrote:
> > On Thu, May 17, 2007 at 05:33:48AM +0800, Antonino A. Daplas wrote:
> > > -#if defined(__sparc__) && !defined(__sparc_v9__)
> > > - /* Should never get here, all fb drivers should have their own
> > > - mmap routines */
> > > - return -EINVAL;
> > > -#else
> > > - /* !sparc32... */
> > > + if (fb_mmap_required())
> > > + return -EINVAL;
> > > +
> >
> > I don't like this bit.
>
> Me too, actually. I did it this way because I don't want to deviate from
> the old code too much. Since all sparc32 drivers are either linked to
> sbuslib.c or has their own fb_mmap method, the above test is redundant.
> I'll leave the decision to remove the above test to David Miller.
Feel free to remove it.
next prev parent reply other threads:[~2007-05-17 20:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 21:33 [PATCH 10/10] [HEADS UP] fbdev: Move arch-specific bits to their respective subdirectories Antonino A. Daplas
2007-05-16 21:33 ` Antonino A. Daplas
2007-05-16 21:53 ` David Miller
2007-05-16 22:59 ` Antonino A. Daplas
2007-05-17 0:54 ` Kumar Gala
2007-05-17 6:13 ` Antonino A. Daplas
2007-05-17 6:13 ` Antonino A. Daplas
2007-05-17 9:43 ` Geert Uytterhoeven
2007-05-17 9:43 ` [Linux-fbdev-devel] " Geert Uytterhoeven
2007-05-17 10:52 ` Antonino A. Daplas
2007-05-17 10:52 ` [Linux-fbdev-devel] " Antonino A. Daplas
2007-05-17 9:49 ` Christoph Hellwig
2007-05-17 10:51 ` Antonino A. Daplas
2007-05-17 10:51 ` Antonino A. Daplas
2007-05-17 20:30 ` David Miller [this message]
2007-05-17 20:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070517.133003.63739733.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adaplas@gmail.com \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.