Re: [PATCH] Add iwlwifi wireless drivers [part 2/2]

[Stephen Hemminger <shemminger@linux-foundation.org>]

On Wed, 16 May 2007 20:35:05 -0700
Randy Dunlap <randy.dunlap@oracle.com> wrote:

> On Wed, 16 May 2007 14:45:32 -0700 James Ketrenos wrote:
> 
> > This patch adds the iwlwifi project directory and sources needed to 
> > build the mac80211 based wireless drivers for the Intel PRO/Wireless 
> > 3945ABG/BG Network Connection and Intel Wireless WiFi Link AGN adapters.
> > 
> > Signed-off-by: James Ketrenos <jketreno@linux.intel.com>
> > 
> > NOTE:  The patch is 597k and can be found at:
> > 
> > 	http://intellinuxwireless.org/iwlwifi/0001-Add-iwlwifi-wireless-drivers.patch
> > 
> > Patch is against wireless-dev commit-id be8662897~
> 
> 
> 1.  Can't this:
> 
> +	if (sizeof(priv->eeprom) != 1024) {
> +		IWL_ERROR("EEPROM structure size incorrect!\n");
> +		return -EINVAL;
> +	}
> 
> use this instead of 1024 ?
> +#define IWL4965_EEPROM_IMAGE_SIZE  (0x200 * sizeof(u16))

Why not BUILD_BUG_ON()?


-- 
Stephen Hemminger <shemminger@linux-foundation.org>