Re: [PATCH] Add iwlwifi wireless drivers

[James Ketrenos <jketreno@linux.intel.com>]

Jeff Garzik wrote:
> James Ketrenos wrote:
>> Randy Dunlap wrote:
>>> 15.  Limit source lines to <= 80 columns (this patch contains
>>> over 200 lines that are > 80 columns).
>>
>> Fixed in the .c files.  Still have 155 instances in the .h files (most 
>> due to mid-line tabs)
> 
> See my email on this subject.  This is NOT a hard and fast rule.  If you 
> have to do something stupid to the formatting to get it to fit, then you 
> are moving in the wrong direction.

The bulk of the problems in the .h files are caused by Lindent injecting tabs instead of spaces between the C language item and the comment describing it, blowing the comments over 80.

That said, some of the define names are horrendously long... over time we can get those cleaned up w/ some sed scripts.

> As an aside, sometimes long lines are an indication that a function 
> needs to be broken up into smaller sub-functions.

Nod.

James