From: Steve Grubb <sgrubb@redhat.com>
To: linux-audit@redhat.com
Cc: Valdis.Kletnieks@vt.edu, Linus Torvalds <torvalds@osdl.org>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] audit: fix broken class-based syscall audit
Date: Thu, 17 May 2007 09:58:25 -0400 [thread overview]
Message-ID: <200705170958.25421.sgrubb@redhat.com> (raw)
In-Reply-To: <16777.1179407950@turing-police.cc.vt.edu>
On Thursday 17 May 2007 09:19, Valdis.Kletnieks@vt.edu wrote:
> > I'd suggest adding a printk() in addition to returning 0 - you don't want
> > to silently ignore unknown or unsupported syscalls when auditing.
>
> Make it rate-limited, so a program can't unintentionally spam your logs.
For this to happen, the syscall would have to be > 2048. I'd almost image
syscalls out of range in general...whether being auditing by class as in this
case or with a typical syscall rule is a problem. So, way back over at
syscall entry would be the time to notice this problem instead of here. If we
are concerned about this, it might be a general control feature like
enable/disable, fail mode, or backlog. We could make something to report out
of range syscalls.
-Steve
next prev parent reply other threads:[~2007-05-17 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 22:45 [PATCH] audit: fix broken class-based syscall audit Klaus Weidner
2007-05-17 13:19 ` Valdis.Kletnieks
2007-05-17 13:58 ` Steve Grubb [this message]
2007-05-17 15:23 ` Klaus Weidner
2007-05-17 15:45 ` Steve Grubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705170958.25421.sgrubb@redhat.com \
--to=sgrubb@redhat.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=linux-audit@redhat.com \
--cc=torvalds@osdl.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.