From: Steve Grubb <sgrubb@redhat.com>
To: Klaus Weidner <klaus@atsec.com>
Cc: Linus Torvalds <torvalds@osdl.org>,
linux-audit@redhat.com, Valdis.Kletnieks@vt.edu,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] audit: fix broken class-based syscall audit
Date: Thu, 17 May 2007 11:45:19 -0400 [thread overview]
Message-ID: <200705171145.19880.sgrubb@redhat.com> (raw)
In-Reply-To: <20070517152333.GE11536@w-m-p.com>
On Thursday 17 May 2007 11:23, Klaus Weidner wrote:
> > So, way back over at syscall entry would be the time to notice this
> > problem instead of here. If we are concerned about this, it might be a
> > general control feature like enable/disable, fail mode, or backlog. We
> > could make something to report out of range syscalls.
>
> Can we agree to do just the simple fix for this issue for now, and maybe
> revisit adding additional sanity checks later if people think they are
> helpful?
Certainly. The patch as submitted is fine and Al ack'ed it. I was thinking we
should have one more cleanup as a separate patch at some point that catches
this at syscall entry and allows ignore/printk/panic selection just like the
fail option for the audit system does. In the case of ignore (which would be
default), your patch is needed.
-Steve
prev parent reply other threads:[~2007-05-17 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 22:45 [PATCH] audit: fix broken class-based syscall audit Klaus Weidner
2007-05-17 13:19 ` Valdis.Kletnieks
2007-05-17 13:58 ` Steve Grubb
2007-05-17 15:23 ` Klaus Weidner
2007-05-17 15:45 ` Steve Grubb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705171145.19880.sgrubb@redhat.com \
--to=sgrubb@redhat.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=klaus@atsec.com \
--cc=linux-audit@redhat.com \
--cc=torvalds@osdl.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.