From: David Miller <davem@davemloft.net>
To: eteo@redhat.com
Cc: linux-kernel@vger.kernel.org, acme@redhat.com
Subject: Re: [2.6 patch] net/llc/llc_conn.c: fix possible NULL dereference
Date: Fri, 18 May 2007 22:59:30 -0700 (PDT) [thread overview]
Message-ID: <20070518.225930.80030089.davem@davemloft.net> (raw)
In-Reply-To: <464E8763.3010609@redhat.com>
From: Eugene Teo <eteo@redhat.com>
Date: Sat, 19 May 2007 13:13:07 +0800
> skb_peek() might return an empty list. skb should be checked before calling
> llc_pdu_sn_hdr() with it.
>
> Spotted by the Coverity checker.
>
> Signed-off-by: Eugene Teo <eteo@redhat.com>
The code checks skb_queue_len() for zero first, therefore NULL is
impossible.
Can you check this kind of stuff before submitting patches like this?
Thank you.
prev parent reply other threads:[~2007-05-19 5:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-19 5:13 [2.6 patch] net/llc/llc_conn.c: fix possible NULL dereference Eugene Teo
2007-05-19 5:30 ` Randy Dunlap
2007-05-19 5:44 ` Eugene Teo
2007-05-19 5:49 ` Eugene Teo
2007-05-19 6:03 ` David Miller
2007-05-19 6:01 ` David Miller
2007-05-19 5:43 ` Herbert Xu
2007-05-19 5:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070518.225930.80030089.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@redhat.com \
--cc=eteo@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.