From: Eugene Teo <eteo@redhat.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [2.6 patch] net/llc/llc_conn.c: fix possible NULL dereference
Date: Sat, 19 May 2007 13:44:55 +0800 [thread overview]
Message-ID: <464E8ED7.6060607@redhat.com> (raw)
In-Reply-To: <20070518223005.91236c38.randy.dunlap@oracle.com>
Hi Randy,
Randy Dunlap wrote:
> On Sat, 19 May 2007 13:13:07 +0800 Eugene Teo wrote:
>
>> skb_peek() might return an empty list. skb should be checked before calling
>> llc_pdu_sn_hdr() with it.
>>
>> Spotted by the Coverity checker.
>>
>> Signed-off-by: Eugene Teo <eteo@redhat.com>
[...]
>
> Networking patches need to be sent to the netdev@vger.kernel.org
> mailing list (and lkml can be omitted IMHO).
>
> But... instead of doing the assignment and test in one swoop,
> we prefer:
Right, thanks for the reminder!
Eugene
next prev parent reply other threads:[~2007-05-19 5:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-19 5:13 [2.6 patch] net/llc/llc_conn.c: fix possible NULL dereference Eugene Teo
2007-05-19 5:30 ` Randy Dunlap
2007-05-19 5:44 ` Eugene Teo [this message]
2007-05-19 5:49 ` Eugene Teo
2007-05-19 6:03 ` David Miller
2007-05-19 6:01 ` David Miller
2007-05-19 5:43 ` Herbert Xu
2007-05-19 5:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464E8ED7.6060607@redhat.com \
--to=eteo@redhat.com \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.