Re: "grub-probe -t partmap" doesn't work with software RAID

[Robert Millan <rmh@aybabtu.com>]

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

On Sun, May 13, 2007 at 06:44:07PM +0200, Robert Millan wrote:
> On Sun, May 13, 2007 at 12:02:26PM +0100, Sam Morris wrote:
> > On Sat, 2007-05-12 at 22:16 +0100, Sam Morris wrote:
> > > On Wed, 2007-05-09 at 18:13 +0200, Robert Millan wrote:
> > > > I'm forwarding you a bug report from Debian.  It seems that the grub-probe
> > > > -t partmap feature I just added doesn't play nice with RAID.  Unfortunately,
> > > > I have no idea how software RAID is implemented.  Is it okay to just exit
> > > > succesfuly and install core.img without any partmap module?
> 
> ... so apparently it isn't.  We still need to detect this somehow, or maybe we
> could just print "pc gpt".. anyone can cast some light on this?

How about this as temporary solution?  It's ugly, but it's not worse than what
we had before.

-- 
Robert Millan

My spam trap is honeypot@aybabtu.com.  Note: this address is only intended
for spam harvesters.  Writing to it will get you added to my black list.

[-- Attachment #2: raid_partmap.diff --]
[-- Type: text/x-diff, Size: 1596 bytes --]

Index: util/i386/efi/grub-install.in
===================================================================
RCS file: /sources/grub/grub2/util/i386/efi/grub-install.in,v
retrieving revision 1.1
diff -u -r1.1 grub-install.in
--- util/i386/efi/grub-install.in	16 May 2007 15:05:02 -0000	1.1
+++ util/i386/efi/grub-install.in	18 May 2007 06:48:02 -0000
@@ -187,7 +187,7 @@
 fi
 
 # Then the partition map module.
-partmap_module=`$grub_probe --target=partmap --device-map=${device_map} ${grubdir}`
+partmap_module=`$grub_probe --target=partmap --device-map=${device_map} ${grubdir} || echo pc gpt`
 if test "x$partmap_module" = x -a "x$modules" = x; then
     echo "Auto-detection of a partition map module failed." 1>&2
     echo "Please specify the module with the option \`--modules' explicitly." 1>&2
Index: util/i386/pc/grub-install.in
===================================================================
RCS file: /sources/grub/grub2/util/i386/pc/grub-install.in,v
retrieving revision 1.13
diff -u -r1.13 grub-install.in
--- util/i386/pc/grub-install.in	7 May 2007 19:54:46 -0000	1.13
+++ util/i386/pc/grub-install.in	18 May 2007 06:48:02 -0000
@@ -217,7 +217,7 @@
 fi
 
 # Then the partition map module.
-partmap_module=`$grub_probe --target=partmap --device-map=${device_map} ${grubdir}`
+partmap_module=`$grub_probe --target=partmap --device-map=${device_map} ${grubdir} || echo pc gpt`
 if test "x$partmap_module" = x -a "x$modules" = x; then
     echo "Auto-detection of a partition map module failed." 1>&2
     echo "Please specify the module with the option \`--modules' explicitly." 1>&2