All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	mingo@elte.hu, ak@suse.de, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, "Zou,
	Nanhai" <nanhai.zou@intel.com>,
	"Mallick, Asit K" <asit.k.mallick@intel.com>,
	"Packard, Keith" <keith.packard@intel.com>
Subject: Re: [patch] x86_64, irq: check remote IRR bit before migrating level triggered irq
Date: Fri, 18 May 2007 11:39:41 -0700	[thread overview]
Message-ID: <20070518183941.GA28957@linux-os.sc.intel.com> (raw)
In-Reply-To: <86802c440705181128t28652911w39d6de0c43d99a45@mail.gmail.com>

On Fri, May 18, 2007 at 11:28:25AM -0700, Yinghai Lu wrote:
> On 5/18/07, Siddha, Suresh B <suresh.b.siddha@intel.com> wrote:
> >
> > If the vector number stays same during irq migration and if we reset remote
> > IRR bit using the above method(edge and then back to level) during
> > irq migration, then we have a problem. A new interrupt arriving on a new
> > cpu will set the remote IRR bit and now the old inflight EOI broadcast
> > reaches IOAPIC RTE(resetting the remote IRR bit, because the vector in the
> > broadcast msg is same), while the kernel code still assumes that the remote
> > IRR bit is still set. This will lead to more problems and issues.
> 
> coud add some line __assign_irq_vector. to make sure old_vector!=vector.

hmm..
what happens when there is second(and very quick) irq migration which brings the
irq back to old cpu(or to a third cpu) with old vector.

Point is, we are not taking care of the inflight messages(which can perhaps,
theoretically, can get delayed for long time)

thanks,
suresh

  reply	other threads:[~2007-05-18 18:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-17 23:03 [patch] x86_64, irq: check remote IRR bit before migrating level triggered irq Siddha, Suresh B
2007-05-17 23:58 ` Eric W. Biederman
2007-05-18  0:43   ` Siddha, Suresh B
2007-05-18  0:30 ` Eric W. Biederman
2007-05-18  1:01   ` Siddha, Suresh B
2007-05-18 14:40     ` Eric W. Biederman
2007-05-18 17:30       ` Yinghai Lu
2007-05-18 18:01         ` Eric W. Biederman
2007-05-18 18:09           ` Yinghai Lu
2007-05-18 18:20             ` Eric W. Biederman
2007-05-18 18:07       ` Siddha, Suresh B
2007-05-18 18:28         ` Yinghai Lu
2007-05-18 18:39           ` Siddha, Suresh B [this message]
2007-05-18 19:02             ` Eric W. Biederman
2007-05-18 19:18               ` Siddha, Suresh B
2007-05-31  2:50         ` Eric W. Biederman
2007-05-18 12:00 ` Andi Kleen
2007-05-18 14:19   ` Eric W. Biederman
2007-05-31 11:34 ` [PATCH] x86_64 irq: check remote IRR bit before migrating level triggered irq (v2) Eric W. Biederman
2007-05-31 12:01   ` Andi Kleen
2007-05-31 13:29     ` Eric W. Biederman
2007-05-31 20:02       ` Siddha, Suresh B
2007-05-31 13:34   ` Ingo Molnar
2007-05-31 13:50     ` [PATCH] x86_64 irq: check remote IRR bit before migrating level triggered irq (v3) Eric W. Biederman
2007-05-31 13:54       ` Ingo Molnar
2007-05-31 20:00       ` Siddha, Suresh B

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070518183941.GA28957@linux-os.sc.intel.com \
    --to=suresh.b.siddha@intel.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=asit.k.mallick@intel.com \
    --cc=ebiederm@xmission.com \
    --cc=keith.packard@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nanhai.zou@intel.com \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.