All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Petr Baudis <pasky@suse.cz>
Cc: git@vger.kernel.org, Junio C Hamano <junkio@cox.net>
Subject: Re: [PATCH] gitweb: Add support for grep searches
Date: Sat, 19 May 2007 02:43:48 +0200	[thread overview]
Message-ID: <200705190243.49788.jnareb@gmail.com> (raw)
In-Reply-To: <20070518123538.GW4489@pasky.or.cz>

Petr Baudis wrote:
> On Fri, May 18, 2007 at 01:58:28PM CEST, Jakub Narebski wrote:

>> Additionally it would be nice to have links from search results page to
>> have search match highlighted, like search results on GitWiki.

For example 
  http://git.or.cz/gitwiki/SubprojectSupport?highlight=%28Subproject%29
 
> I'm sorry, I don't understand.

For example search results for commit search ('author', 'committer'
and 'commit' searches have link to 'commit' view. Pickaxe has link
to 'commitdiff' view. Grep search would have link(s) to blob views.
In those views the 's' (searchtext) parameter could be passed, and
matched fragment should be somehow higlighted, e.g. using background
color to not interfere with syntax highlighting.

-- 
Jakub Narebski
Poland

  reply	other threads:[~2007-05-19  0:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-17  2:31 [PATCH] gitweb: Add support for grep searches Petr Baudis
2007-05-17  9:00 ` Jakub Narebski
2007-05-18 11:58 ` Jakub Narebski
2007-05-18 12:35   ` Petr Baudis
2007-05-19  0:43     ` Jakub Narebski [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-04-27  3:41 Petr Baudis
2007-04-27  3:47 ` Petr Baudis
2007-04-27  3:59   ` Linus Torvalds
2007-04-27  4:21     ` Petr Baudis
2007-04-27  4:21     ` Petr Baudis
2007-04-27  4:34     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200705190243.49788.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.