All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Add support for grep searches
Date: Thu, 17 May 2007 11:00:10 +0200	[thread overview]
Message-ID: <f2h59r$sge$1@sea.gmane.org> (raw)
In-Reply-To: 20070517023112.21056.62390.stgit@rover

Petr Baudis wrote:

> This second revision makes it in documentation explicit that grep accepts
> regexps, and makes grep accept extended regexps instead of basic regexps.

I have thought about adding "[ ] regular expression" (or "Perl
extended regexp", or something like that) checkbox for all searches:
'commit' (message), 'pickaxe' and the new 'grep'.

I have thought also about replaceing pickaxe search pipeline by
  git log --pretty=format:%H -r --no-abbrev --raw -S<search> <hash>
but I'm not sure if pager would be turned off, and of performance
compared to current pipeline:
  git rev-list <hash> | git diff-tree -r --stdin -S<search>

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

  reply	other threads:[~2007-05-17  8:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-17  2:31 [PATCH] gitweb: Add support for grep searches Petr Baudis
2007-05-17  9:00 ` Jakub Narebski [this message]
2007-05-18 11:58 ` Jakub Narebski
2007-05-18 12:35   ` Petr Baudis
2007-05-19  0:43     ` Jakub Narebski
  -- strict thread matches above, loose matches on Subject: below --
2007-04-27  3:41 Petr Baudis
2007-04-27  3:47 ` Petr Baudis
2007-04-27  3:59   ` Linus Torvalds
2007-04-27  4:21     ` Petr Baudis
2007-04-27  4:21     ` Petr Baudis
2007-04-27  4:34     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='f2h59r$sge$1@sea.gmane.org' \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.