Re: [RFC, PATCH 9/15] knfsd: add RDMA debug class to rpc_debug bitfield

[Greg Banks <gnb@sgi.com>]

On Sun, May 20, 2007 at 10:31:15PM -0500, Tom Tucker wrote:
> 
> BTW, Chuck Lever also pointed out that we should probably have a generic
> RPCDBG_XPRT debug flag instead of RPCDBG_RDMA.

So he did.  Serves me right for not reading all my email before
replying.

> I think he's right. I think
> this should be part of the transport patchset that you're working on. Do you
> agree?

I'm a little confused as to precisely what is suggested.

Currently we have an existing RPCDBG_SVCSOCK which enables dprintks
in both the generic transport code and in the sockets-specific code
too; this is hard to separate because all the code is intermingled in
the one file svcsock.c.

If the suggestion is to have separate bits for the sockets-specific
and the generic code, then the two painful alternatives seem to be

a) splitting the sockets and generic code into separate .c files, or

b) changing half the dprintk()s in svcsock.c to dfprintks().

I wasn't planning to do either of those anytime soon; either would
be a significant change.

I think the ideal case would be a total of 3 debug bits: one for the
generic transport code, one for the sockets transport-specific code and
one for the RDMA transport-specific code.  Getting there isn't easy.

However given that the new svc_rdma* code is large and in separate
files, giving it it's own RPCDBG_RDMA bit, as you've already done,
is easy and useful and a step in the right direction.

In any case I'm happy to do whatever is necessary in the transport
patchset,  but I'd appreciate Neil's guidance on which approach he'd
prefer before I go in with the scalpel.  Neil?

Greg.
-- 
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
Apparently, I'm Bedevere.  Which MPHG character are you?
I don't speak for SGI.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs