Re: [RFC, PATCH 9/15] knfsd: add RDMA debug class to rpc_debug bitfield

[Tom Tucker <tom@opengridcomputing.com>]

BTW, Chuck Lever also pointed out that we should probably have a generic
RPCDBG_XPRT debug flag instead of RPCDBG_RDMA. I think he's right. I think
this should be part of the transport patchset that you're working on. Do you
agree?

Tom

On 5/20/07 10:19 PM, "Greg Banks" <gnb@sgi.com> wrote:

> On Fri, May 18, 2007 at 12:45:45PM -0500, Tom Tucker wrote:
>> 
>> Add a bit to the rpc_debug bit field for RDMA transport
>> debug messages and sysctl definitions for configuration
>> and statistics files in /proc/sys/sunrpc/svc_rdma.
>> 
>> Signed-off-by: Tom Tucker <tom@opengridcomputing.com>
>> ---
>> 
>>  include/linux/sunrpc/debug.h |   15 +++++++++++++++
>>  1 files changed, 15 insertions(+), 0 deletions(-)
>> 
>> diff --git a/include/linux/sunrpc/debug.h b/include/linux/sunrpc/debug.h
>> index fc3a5dd..9bf7381 100644
>> --- a/include/linux/sunrpc/debug.h
>> +++ b/include/linux/sunrpc/debug.h
>> @@ -24,6 +24,7 @@ #define RPCDBG_SVCSOCK  0x0100
>>  #define RPCDBG_SVCDSP  0x0200
>>  #define RPCDBG_MISC  0x0400
>>  #define RPCDBG_CACHE  0x0800
>> +#define RPCDBG_RDMA  0x1000
>>  #define RPCDBG_ALL  0x7fff
> 
> Fine.  Did you update the rpc_debug program in nfs-utils, which also
> knows about these debug bits?
> 
>>  #ifdef __KERNEL__
>> @@ -93,6 +94,20 @@ enum {
>> CTL_RDMA_MAXINLINEWRITE,
>> CTL_RDMA_WRITEPADDING,
>> CTL_RDMA_MEMREG,
>> + CTL_SVCRDMA,
>> + CTL_RDMA_MAX_REQUESTS,
>> + CTL_RDMA_MAX_REQ_SIZE,
>> + CTL_RDMA_ORD,
>> + CTL_RDMA_READ_THROTTLE,
>> + CTL_RDMA_STAT_RECV,
>> + CTL_RDMA_STAT_READ,
>> + CTL_RDMA_STAT_WRITE,
>> + CTL_RDMA_STAT_SQ_STARVE,
>> + CTL_RDMA_STAT_RQ_STARVE,
>> + CTL_RDMA_STAT_RQ_POLL,
>> + CTL_RDMA_STAT_RQ_PROD,
>> + CTL_RDMA_STAT_SQ_POLL,
>> + CTL_RDMA_STAT_SQ_PROD
>>  };
>>  
>>  #endif /* _LINUX_SUNRPC_DEBUG_H_ */
> 
> This is fine, but one tiny nit: you have the makings of two patches
> here.  This hunk belongs with the patch that uses the new defines
> and registers the sysctls.
> 
> Greg.



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs