All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@sous-sol.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Chris Wright <chrisw@sous-sol.org>,
	Virtualization Mailing List <virtualization@lists.osdl.org>
Subject: Re: changing definition of paravirt_ops.iret
Date: Mon, 21 May 2007 09:46:36 -0700	[thread overview]
Message-ID: <20070521164636.GC3429@sequoia.sous-sol.org> (raw)
In-Reply-To: <4651C865.9090605@goop.org>

* Jeremy Fitzhardinge (jeremy@goop.org) wrote:
> I'm implementing a more efficient version of the Xen iret paravirt_op,
> so that it can use the real iret instruction where possible.  I really
> need to get access to per-cpu variables, so I can set the event mask
> state in the vcpu_info structure, but unfortunately at the point where
> INTERRUPT_RETURN is used in entry.S, the usermode %fs has already been
> restored.
> 
> How would you feel if we changed paravirt_ops.iret to make it also
> responsible for restoring %fs? 

This is definitely ad-hoc semantic change, but I don't see a beter
way to do it (other than have iret be restore_regs_and_iret, which
isn't really an improvement).

thanks,
-chris

  reply	other threads:[~2007-05-21 16:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-21 16:27 changing definition of paravirt_ops.iret Jeremy Fitzhardinge
2007-05-21 16:46 ` Chris Wright [this message]
2007-05-21 16:53   ` Jeremy Fitzhardinge
2007-05-21 18:37 ` Zachary Amsden
2007-05-22  0:08   ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070521164636.GC3429@sequoia.sous-sol.org \
    --to=chrisw@sous-sol.org \
    --cc=jeremy@goop.org \
    --cc=virtualization@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.