From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Chris Wright <chrisw@sous-sol.org>
Cc: Virtualization Mailing List <virtualization@lists.osdl.org>
Subject: Re: changing definition of paravirt_ops.iret
Date: Mon, 21 May 2007 17:53:14 +0100 [thread overview]
Message-ID: <4651CE7A.40904@goop.org> (raw)
In-Reply-To: <20070521164636.GC3429@sequoia.sous-sol.org>
Chris Wright wrote:
> This is definitely ad-hoc semantic change, but I don't see a beter
> way to do it (other than have iret be restore_regs_and_iret, which
> isn't really an improvement).
I just realized its a bit nastier than that. There's also the issue of
removing the error_code from the stack, which is above %fs. So it
becomes "restore %fs, remove error_code and iret".
Also, the INTERRUPT_RETURN in nmi_espfix_stack needs us to actually push
%fs and an error code, just so that it can be removed (but I have no
idea whether this is actually correct; it's very much Zach territory).
J
next prev parent reply other threads:[~2007-05-21 16:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 16:27 changing definition of paravirt_ops.iret Jeremy Fitzhardinge
2007-05-21 16:46 ` Chris Wright
2007-05-21 16:53 ` Jeremy Fitzhardinge [this message]
2007-05-21 18:37 ` Zachary Amsden
2007-05-22 0:08 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4651CE7A.40904@goop.org \
--to=jeremy@goop.org \
--cc=chrisw@sous-sol.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.