[PATCH -ak] Fix missing include

[PATCH -ak] Fix missing include

[Thomas Gleixner]

ftp://firstfloor.org/pub/ak/x86_64/quilt/x86_64-2.6.22-rc2-070521-1.bz2

explodes in various places due to missing defines of __cold. We can't
rely on the assumption that linux/compiler.h is included magically
before bug.h is included. Include it explicitely.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Index: linux-2.6.22-rc2-ak/include/asm-i386/bug.h
===================================================================
--- linux-2.6.22-rc2-ak.orig/include/asm-i386/bug.h
+++ linux-2.6.22-rc2-ak/include/asm-i386/bug.h
@@ -8,6 +8,9 @@
  */
 
 #ifdef CONFIG_BUG
+
+#include <linux/compiler.h>
+
 #define HAVE_ARCH_BUG
 
 #ifdef CONFIG_DEBUG_BUGVERBOSE
Index: linux-2.6.22-rc2-ak/include/asm-x86_64/bug.h
===================================================================
--- linux-2.6.22-rc2-ak.orig/include/asm-x86_64/bug.h
+++ linux-2.6.22-rc2-ak/include/asm-x86_64/bug.h
@@ -2,6 +2,9 @@
 #define __ASM_X8664_BUG_H 1
 
 #ifdef CONFIG_BUG
+
+#include <linux/compiler.h>
+
 #define HAVE_ARCH_BUG
 
 #ifdef CONFIG_DEBUG_BUGVERBOSE

Re: [PATCH -ak] Fix missing include

[Andi Kleen]

On Monday 21 May 2007 22:03, Thomas Gleixner wrote:
> ftp://firstfloor.org/pub/ak/x86_64/quilt/x86_64-2.6.22-rc2-070521-1.bz2
>
> explodes in various places due to missing defines of __cold. We can't
> rely on the assumption that linux/compiler.h is included magically
> before bug.h is included. Include it explicitely.

Hmm, somehow it worked here. Perhaps longer term it would be a good
idea to turn compiler.h into an -include

> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Added thanks

-Andi

Re: [PATCH -ak] Fix missing include

[Thomas Gleixner]

On Tue, 2007-05-22 at 08:20 +0200, Andi Kleen wrote:
> On Monday 21 May 2007 22:03, Thomas Gleixner wrote:
> > ftp://firstfloor.org/pub/ak/x86_64/quilt/x86_64-2.6.22-rc2-070521-1.bz2
> >
> > explodes in various places due to missing defines of __cold. We can't
> > rely on the assumption that linux/compiler.h is included magically
> > before bug.h is included. Include it explicitely.
> 
> Hmm, somehow it worked here. Perhaps longer term it would be a good
> idea to turn compiler.h into an -include

Might be not a bad idea. > 300 files include it directly and it's
included from sched.h & co as well.

	tglx

Re: [PATCH -ak] Fix missing include

[Sam Ravnborg]

On Tue, May 22, 2007 at 09:28:15AM +0200, Thomas Gleixner wrote:
> On Tue, 2007-05-22 at 08:20 +0200, Andi Kleen wrote:
> > On Monday 21 May 2007 22:03, Thomas Gleixner wrote:
> > > ftp://firstfloor.org/pub/ak/x86_64/quilt/x86_64-2.6.22-rc2-070521-1.bz2
> > >
> > > explodes in various places due to missing defines of __cold. We can't
> > > rely on the assumption that linux/compiler.h is included magically
> > > before bug.h is included. Include it explicitely.
> > 
> > Hmm, somehow it worked here. Perhaps longer term it would be a good
> > idea to turn compiler.h into an -include
> 
> Might be not a bad idea. > 300 files include it directly and it's
> included from sched.h & co as well.

How about a file like:
include/linux/always_include.h

This file could then include autoconf.h + compiler.h
So we avoid an even longer gcc commandline.

	Sam