All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ivan Kuten <ivan.kuten@promwad.com>
To: Andrew Victor <andrew@sanpeople.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: PATCH: at91_nand rdy_pin fix
Date: Thu, 24 May 2007 11:14:06 +0300	[thread overview]
Message-ID: <20070524111406.0b11fb5d@newbox> (raw)
In-Reply-To: <1179992828.13098.26.camel@fuzzie.sanpeople.com>

On 24 May 2007 09:47:08 +0200
Andrew Victor wrote:

Should I re-diff or you will apply it corrected?

BR, 
Ivan

> hi Ivan,
> 
> > -       nand_chip->dev_ready = at91_nand_device_ready;
> > +
> > +       if (host->board->rdy_pin)
> > +               nand_chip->dev_ready = at91_nand_device_ready;
> > +       else
> > +               nand_chip->dev_ready = NULL;
> 
> Patch looks correct.
> 
> Since the at91_nand_host structure is allocated with kzalloc(),
> nand_chip->dev_ready is already initialized to NULL.
> So we don't really need the "else" part.
> 
> 
> Regards,
>   Andrew Victor
> 
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2007-05-24  8:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-23 21:53 PATCH: at91_nand rdy_pin fix Ivan Kuten
2007-05-24  7:47 ` Andrew Victor
2007-05-24  8:14   ` Ivan Kuten [this message]
2007-05-24 11:35   ` Ivan Kuten
  -- strict thread matches above, loose matches on Subject: below --
2007-06-28 19:14 Ivan Kuten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070524111406.0b11fb5d@newbox \
    --to=ivan.kuten@promwad.com \
    --cc=andrew@sanpeople.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.