All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Ben Collins <bcollins@ubuntu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] RTC: Ratelimit "lost interrupts" message
Date: Thu, 24 May 2007 13:48:22 -0700	[thread overview]
Message-ID: <20070524134822.ed020127.akpm@linux-foundation.org> (raw)
In-Reply-To: <e5ea703bf068a19cc9a4cc76a9b6b8990380ee75.1179964369.git.bcollins@ubuntu.com>

On Wed, 23 May 2007 18:23:06 -0400
Ben Collins <bcollins@ubuntu.com> wrote:

> Signed-off-by: Ben Collins <bcollins@ubuntu.com>
> ---
>  drivers/char/rtc.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/rtc.c b/drivers/char/rtc.c
> index 20380a2..22cf7aa 100644
> --- a/drivers/char/rtc.c
> +++ b/drivers/char/rtc.c
> @@ -1159,7 +1159,8 @@ static void rtc_dropped_irq(unsigned long data)
>  
>  	spin_unlock_irq(&rtc_lock);
>  
> -	printk(KERN_WARNING "rtc: lost some interrupts at %ldHz.\n", freq);
> +	if (printk_ratelimit())
> +		printk(KERN_WARNING "rtc: lost some interrupts at %ldHz.\n", freq);
>  

Presumably someone is getting a lot of these messages.

Do we know why?  Is there something which needs fixing here?

  reply	other threads:[~2007-05-24 20:48 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-23 21:59 [PATCH 0/6] Patch sync from Ubuntu tree Ben Collins
2007-05-23 21:59 ` [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper Ben Collins
2007-05-24  3:15   ` Randy Dunlap
2007-05-24 20:44   ` [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper (fixed) Andrew Morton
2007-05-25 11:33   ` [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper Andi Kleen
2007-05-25 12:52     ` Ben Collins
2007-05-25 19:45       ` H. Peter Anvin
2007-05-25 23:23         ` Jesse Barnes
2007-05-25 23:28           ` H. Peter Anvin
2007-05-25 23:38             ` Jesse Barnes
2007-05-25 23:43               ` H. Peter Anvin
2007-05-25 23:50                 ` Jesse Barnes
2007-05-25 23:50             ` Ben Collins
2007-05-25 23:52               ` H. Peter Anvin
2007-05-23 22:18 ` [PATCH 2/6] PM: Do not require dev spew to get PM_DEBUG Ben Collins
2007-05-23 22:21 ` [PATCH 3/6] HCIUSB: Initialize the Broadcom USB Bluetooth device in Dell laptops Ben Collins
2007-05-24 17:02   ` Marcel Holtmann
2007-05-24 17:33     ` Ben Collins
2007-05-23 22:23 ` [PATCH 4/6] RTC: Ratelimit "lost interrupts" message Ben Collins
2007-05-24 20:48   ` Andrew Morton [this message]
2007-05-24 20:56     ` Ben Collins
2007-05-24 21:09       ` Andrew Morton
2007-05-24 21:15         ` Roland Dreier
2007-05-24 21:16         ` Zachary Amsden
2007-05-23 22:30 ` [PATCH 5/6] SUNHME: Workaround ancient hang on U1's Ben Collins
2007-05-24  0:17   ` David Miller
2007-05-24  1:59     ` Ben Collins
2007-05-24 12:30   ` Daniel Drake
2007-05-23 22:39 ` [PATCH 6/6] UNUSUAL_DEV: Sync up some reported devices from Ubuntu Ben Collins
2007-05-24  3:59   ` Phil Dibowitz
2007-05-24  4:09     ` Ben Collins
2007-05-30 21:50   ` Dave Jones
2007-05-30 22:25     ` Phil Dibowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070524134822.ed020127.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=bcollins@ubuntu.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.