From: Adam Osuchowski <adwol@zonk.pl>
To: bridge@lists.linux-foundation.org
Cc: linux-kernel@vger.kernel.org
Subject: [Bridge] [BUG] Dropping fragmented IP packets within VLAN frames on bridge
Date: Fri, 25 May 2007 10:17:50 +0200 [thread overview]
Message-ID: <20070525081750.5ba4a411@zonk.pl> (raw)
There is a problem with fragmented IP packet sent within 802.1Q tagged
ethernet frame through bridge. Problem exists when conntrack is enabled
(i.e. nf_conntrack_ipv4 module is loaded). Then, such packets are not
fragmented again (after prior reassembling on bridge device) during
passing it to bridge enslaved NIC. It cause MTU exceeding and as a result
dropping packet.
Problem exists from kernel version 2.6.17 to 2.6.21.3 inclusive.
Below, there is a patch to fix it.
Regards.
--- linux-2.6.21.3.orig/net/bridge/br_netfilter.c 2007-05-25 09:56:15.000000000 +0200
+++ linux-2.6.21.3/net/bridge/br_netfilter.c 2007-05-25 10:11:42.000000000 +0200
@@ -731,7 +731,7 @@
static int br_nf_dev_queue_xmit(struct sk_buff *skb)
{
- if (skb->protocol == htons(ETH_P_IP) &&
+ if ((skb->protocol == htons(ETH_P_IP) || IS_VLAN_IP(skb)) &&
skb->len > skb->dev->mtu &&
!skb_is_gso(skb))
return ip_fragment(skb, br_dev_queue_push_xmit);
WARNING: multiple messages have this Message-ID (diff)
From: Adam Osuchowski <adwol@zonk.pl>
To: bridge@lists.linux-foundation.org
Cc: linux-kernel@vger.kernel.org
Subject: [BUG] Dropping fragmented IP packets within VLAN frames on bridge
Date: Fri, 25 May 2007 10:17:50 +0200 [thread overview]
Message-ID: <20070525081750.5ba4a411@zonk.pl> (raw)
There is a problem with fragmented IP packet sent within 802.1Q tagged
ethernet frame through bridge. Problem exists when conntrack is enabled
(i.e. nf_conntrack_ipv4 module is loaded). Then, such packets are not
fragmented again (after prior reassembling on bridge device) during
passing it to bridge enslaved NIC. It cause MTU exceeding and as a result
dropping packet.
Problem exists from kernel version 2.6.17 to 2.6.21.3 inclusive.
Below, there is a patch to fix it.
Regards.
--- linux-2.6.21.3.orig/net/bridge/br_netfilter.c 2007-05-25 09:56:15.000000000 +0200
+++ linux-2.6.21.3/net/bridge/br_netfilter.c 2007-05-25 10:11:42.000000000 +0200
@@ -731,7 +731,7 @@
static int br_nf_dev_queue_xmit(struct sk_buff *skb)
{
- if (skb->protocol == htons(ETH_P_IP) &&
+ if ((skb->protocol == htons(ETH_P_IP) || IS_VLAN_IP(skb)) &&
skb->len > skb->dev->mtu &&
!skb_is_gso(skb))
return ip_fragment(skb, br_dev_queue_push_xmit);
next reply other threads:[~2007-05-25 8:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 8:17 Adam Osuchowski [this message]
2007-05-25 8:17 ` [BUG] Dropping fragmented IP packets within VLAN frames on bridge Adam Osuchowski
2007-05-25 15:59 ` [Bridge] " Stephen Hemminger
2007-05-25 17:49 ` Adam Osuchowski
2007-05-25 18:00 ` Stephen Hemminger
2007-05-25 18:17 ` Adam Osuchowski
2007-05-25 18:28 ` Stephen Hemminger
2007-05-25 18:49 ` Adam Osuchowski
2007-05-26 8:13 ` Patrick McHardy
2007-05-26 8:13 ` Patrick McHardy
2007-05-26 14:20 ` Ingo Oeser
2007-05-26 14:20 ` Ingo Oeser
2007-05-26 15:05 ` Patrick McHardy
2007-05-26 15:05 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070525081750.5ba4a411@zonk.pl \
--to=adwol@zonk.pl \
--cc=bridge@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.