All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Kosina <jikos@jikos.cz>
Cc: Yoann Padioleau <padator@wanadoo.fr>,
	kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: [KJ] Re: [PATCH] potential parse error in ifdef
Date: Fri, 25 May 2007 16:41:36 +0000	[thread overview]
Message-ID: <20070525094136.00be86ae.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0705251349330.8531@twin.jikos.cz>

On Fri, 25 May 2007 13:50:37 +0200 (CEST) Jiri Kosina <jikos@jikos.cz> wrote:

> On Fri, 25 May 2007, Yoann Padioleau wrote:
> 
> > I have made a tool to parse the kernel that does not pre-process the
> > source. That means that my parser tries to parse all the code, including
> > code in the #else branch or code that is not often compiled because
> > the driver is not very used (or not used at all). So, my parser
> > sometimes reports parse error not originally detected by gcc. 
> > Here is my (first) patch.
> >  drivers/char/watchdog/ixp2000_wdt.c |    2 +-
> >  drivers/mtd/devices/pmc551.c        |    2 +-
> >  drivers/mtd/nand/autcpu12.c         |    2 +-
> >  drivers/mtd/nand/ppchameleonevb.c   |    2 +-
> >  drivers/net/amd8111e.c              |    2 +-
> >  drivers/net/skfp/smt.c              |    2 +-
> >  drivers/scsi/aic7xxx/aic79xx_core.c |    2 +-
> >  sound/arm/sa11xx-uda1341.c          |    2 +-
> >  8 files changed, 8 insertions(+), 8 deletions(-)
> 
> As these are totally independent fixes across various subsystems, you 
> should probably split the patch into per-subsystem patches and submit them 
> separately.

That's normally true, yes.  But for a bunch of obviously-better one-line
fixes in code which nobody has even compiled in ages, I think we can bend
the rules a bit and just slam it in.

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Kosina <jikos@jikos.cz>
Cc: Yoann Padioleau <padator@wanadoo.fr>,
	kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] potential parse error in ifdef
Date: Fri, 25 May 2007 09:41:36 -0700	[thread overview]
Message-ID: <20070525094136.00be86ae.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0705251349330.8531@twin.jikos.cz>

On Fri, 25 May 2007 13:50:37 +0200 (CEST) Jiri Kosina <jikos@jikos.cz> wrote:

> On Fri, 25 May 2007, Yoann Padioleau wrote:
> 
> > I have made a tool to parse the kernel that does not pre-process the
> > source. That means that my parser tries to parse all the code, including
> > code in the #else branch or code that is not often compiled because
> > the driver is not very used (or not used at all). So, my parser
> > sometimes reports parse error not originally detected by gcc. 
> > Here is my (first) patch.
> >  drivers/char/watchdog/ixp2000_wdt.c |    2 +-
> >  drivers/mtd/devices/pmc551.c        |    2 +-
> >  drivers/mtd/nand/autcpu12.c         |    2 +-
> >  drivers/mtd/nand/ppchameleonevb.c   |    2 +-
> >  drivers/net/amd8111e.c              |    2 +-
> >  drivers/net/skfp/smt.c              |    2 +-
> >  drivers/scsi/aic7xxx/aic79xx_core.c |    2 +-
> >  sound/arm/sa11xx-uda1341.c          |    2 +-
> >  8 files changed, 8 insertions(+), 8 deletions(-)
> 
> As these are totally independent fixes across various subsystems, you 
> should probably split the patch into per-subsystem patches and submit them 
> separately.

That's normally true, yes.  But for a bunch of obviously-better one-line
fixes in code which nobody has even compiled in ages, I think we can bend
the rules a bit and just slam it in.


  reply	other threads:[~2007-05-25 16:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-21 16:39 [KJ] [PATCH] potential parse error in ifdef Yoann Padioleau
2007-05-21 17:01 ` Matthew Wilcox
2007-05-22  8:21 ` Yoann Padioleau
2007-05-22 23:10 ` Håkon Løvdal
2007-05-22 23:12 ` Cripps
2007-05-23  7:32 ` walter harms
2007-05-23  7:46 ` Yoann Padioleau
2007-05-23  8:18 ` Robert P. J. Day
2007-05-25  7:56 ` Yoann Padioleau
2007-05-25  7:56   ` Yoann Padioleau
2007-05-25 11:50   ` [KJ] " Jiri Kosina
2007-05-25 11:50     ` Jiri Kosina
2007-05-25 16:41     ` Andrew Morton [this message]
2007-05-25 16:41       ` Andrew Morton
2007-06-04 18:29 ` [KJ] [PATCH] potential parse error in ifdef part 3 Yoann Padioleau
2007-06-04 18:29   ` Yoann Padioleau
2007-06-05  7:43   ` [KJ] " Geert Uytterhoeven
2007-06-05  7:43     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070525094136.00be86ae.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=jikos@jikos.cz \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=padator@wanadoo.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.