From: linas@austin.ibm.com (Linas Vepstas)
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, bzolnier@gmail.com,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andries.Brouwer@cwi.nl, michal.kepien@poczta.onet.pl
Subject: Re: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x
Date: Fri, 25 May 2007 12:58:30 -0500 [thread overview]
Message-ID: <20070525175830.GA4323@austin.ibm.com> (raw)
In-Reply-To: <465607D8.3030207@ru.mvista.com>
On Fri, May 25, 2007 at 01:47:04AM +0400, Sergei Shtylyov wrote:
> Hello, I wrote:
>
> >>> Linas, Andries, Michal, cound you try this instead:
> >>>
> >>> d->enablebits[0].mask = d->enablebits[0].val = 0x10;
>
> > It probably won't work the way it should anyway -- the secondary
> >channel (and controller in this case) uses another bit in this register
> >and the controllers get registered with IDE core "in pair".
Setting d->enablebits[0].mask = d->enablebits[0].val = 0x10; makes
my system bootable, and so this works well enough for me. Without this
patch, mainline 2.6.21.1 is broken, and so I'll say it again:
Please submit a patch to the stable branch so that this gets generically
fixed! I'll happily Ack it.
--linas
next prev parent reply other threads:[~2007-05-25 17:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 19:18 [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x Sergei Shtylyov
2007-05-05 19:30 ` Bartlomiej Zolnierkiewicz
2007-05-05 20:18 ` Sergei Shtylyov
2007-05-05 21:20 ` Bartlomiej Zolnierkiewicz
2007-05-06 22:53 ` Andries Brouwer
2007-05-24 20:23 ` Sergei Shtylyov
2007-05-24 20:34 ` Linas Vepstas
2007-05-24 20:53 ` Sergei Shtylyov
2007-05-24 21:06 ` Linas Vepstas
2007-05-24 21:47 ` Sergei Shtylyov
2007-05-25 17:58 ` Linas Vepstas [this message]
2007-05-25 18:12 ` Sergei Shtylyov
2007-05-28 20:32 ` Andries Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070525175830.GA4323@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=Andries.Brouwer@cwi.nl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=michal.kepien@poczta.onet.pl \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.