Re: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello, I wrote:
> HPT36x chip don't seem to have the channel enable bits, so prevent the IDE core
> from checking them...

> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

> Index: linux-2.6/drivers/ide/pci/hpt366.c
> ===================================================================
> --- linux-2.6.orig/drivers/ide/pci/hpt366.c
> +++ linux-2.6/drivers/ide/pci/hpt366.c
> @@ -1,5 +1,5 @@
>  /*
> - * linux/drivers/ide/pci/hpt366.c		Version 1.02	Apr 18, 2007
> + * linux/drivers/ide/pci/hpt366.c		Version 1.03	May 4, 2007
>   *
>   * Copyright (C) 1999-2003		Andre Hedrick <andre@linux-ide.org>
>   * Portions Copyright (C) 2001	        Sun Microsystems, Inc.
> @@ -1527,7 +1527,12 @@ static int __devinit init_setup_hpt366(s
>  	if (rev > 2)
>  		goto init_single;
>  
> +	/*
> +	 * HPT36x chips are single channel and
> +	 * do not seem to have the channel enable bit...
> +	 */

    Actually it does, but the bit is different. :-/

>  	d->channels = 1;
> +	d->enablebits[0].reg = 0;

    Linas, Andries, Michal, cound you try this instead:

	d->enablebits[0].mask = d->enablebits[0].val = 0x10;

>  	if ((dev2 = pci_get_slot(dev->bus, dev->devfn + 1)) != NULL) {
>  	  	u8  pin1 = 0, pin2 = 0;

MBR, Sergei