[KJ] looking for a project?

[KJ] looking for a project?

[Robert P. J. Day]

  there's still lots to be done here:

http://fsdev.net/wiki/index.php?title=ARRAY_SIZE

with respect to replacing all those silly C constructs that calculate
an array size with the ARRAY_SIZE macro.

  and i wouldn't even try to do it automatically with a script, since
there are numerous places where you can be a bit more clever than just
a mindless substitution.

  for instance, there are places in the tree that define their own
version of that macro:

drivers/ide/ide-cd.h:#define ARY_LEN(a) ((sizeof(a) / sizeof(a[0])))

that suggests that the ide-cd code uses ARY_LEN() at least once.  so
you could not only replace those calls to ARY_LEN with ARRAY_SIZE, but
you could then delete the macro definition of ARY_LEN.

  if you want to see where similar things are done, just run:

$ grep -r "define.*sizeof.*/.*sizeof" *

of course, not all of those hits represent possible changes, but
there's no lack of work there.

rday

-- 
====================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
====================================
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] looking for a project?

[Cripps]

Wow. That looks like one helluva project ... I'd like to undertake
starting this in the drivers/ subsystem ... I can't start on it right
now (because it's late), but I will have a few looks at it over the
weekend.
Can you offer me any hints for working on this?
-Aaron Cripps
(sorry for the duplicate again Robert ... I keep forgetting the CC address).

On 5/24/07, Robert P. J. Day <rpjday@mindspring.com> wrote:
>
>   there's still lots to be done here:
>
> http://fsdev.net/wiki/index.php?title=ARRAY_SIZE
>
> with respect to replacing all those silly C constructs that calculate
> an array size with the ARRAY_SIZE macro.
>
>   and i wouldn't even try to do it automatically with a script, since
> there are numerous places where you can be a bit more clever than just
> a mindless substitution.
>
>   for instance, there are places in the tree that define their own
> version of that macro:
>
> drivers/ide/ide-cd.h:#define ARY_LEN(a) ((sizeof(a) / sizeof(a[0])))
>
> that suggests that the ide-cd code uses ARY_LEN() at least once.  so
> you could not only replace those calls to ARY_LEN with ARRAY_SIZE, but
> you could then delete the macro definition of ARY_LEN.
>
>   if you want to see where similar things are done, just run:
>
> $ grep -r "define.*sizeof.*/.*sizeof" *
>
> of course, not all of those hits represent possible changes, but
> there's no lack of work there.
>
> rday
>
> --
> ====================================
> Robert P. J. Day
> Linux Consulting, Training and Annoying Kernel Pedantry
> Waterloo, Ontario, CANADA
>
> http://fsdev.net/wiki/index.php?title=Main_Page
> ====================================
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
>
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] looking for a project?

[Andi Drebes]

Hi!

> Wow. That looks like one helluva project ... I'd like to undertake
> starting this in the drivers/ subsystem ... I can't start on it right
> now (because it's late), but I will have a few looks at it over the
> weekend.
<snip>

I just had a look on that and I found quite a lot of places that have to be 
fixed. Currently, I'm inspecting and fixing files in drivers/block, 
drivers/atm and drivers/char. I also found suspicious lines in the arch 
directory. Do you prefer to do the whole thing on your own or would you like 
me to work there, too? I don't want to duplicate work, neither grab the 
project away.

	Cheers,
		Andi
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors