Re: [KJ] looking for a project? (ARRAY_SIZE)

Re: [KJ] looking for a project? (ARRAY_SIZE)

[Robert P. J. Day]

On Thu, 24 May 2007, Cripps wrote:

> Wow. That looks like one helluva project ... I'd like to undertake
> starting this in the drivers/ subsystem ... I can't start on it right
> now (because it's late), but I will have a few looks at it over the
> weekend.
> Can you offer me any hints for working on this?

ok, i've updated the wiki page for the ARRAY_SIZE stuff:

  http://fsdev.net/wiki/index.php?title=ARRAY_SIZE

to get started, i suggest you pick a small subsystem, do the cleanup
there, submit the resulting patch to this list, and we'll let you know
if it was done properly.  in short order, we should converge on the
right solution and you can start doing all the rest of them.

rday

p.s.  feel free to edit the wiki page to make it clearer, or suggest
improvements.
-- 
====================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
====================================
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] looking for a project? (ARRAY_SIZE)

[Cripps]

> ok, i've updated the wiki page for the ARRAY_SIZE stuff:
>
>   http://fsdev.net/wiki/index.php?title=ARRAY_SIZE
>
> to get started, i suggest you pick a small subsystem, do the cleanup
> there, submit the resulting patch to this list, and we'll let you know
> if it was done properly.  in short order, we should converge on the
> right solution and you can start doing all the rest of them.
>
> rday
>
> p.s.  feel free to edit the wiki page to make it clearer, or suggest
> improvements.
> --
> ====================================
> Robert P. J. Day
> Linux Consulting, Training and Annoying Kernel Pedantry
> Waterloo, Ontario, CANADA
>
> http://fsdev.net/wiki/index.php?title=Main_Page
> ====================================

Okay, thanks Robert.
I'll start on the linux-2.6/drivers/net subsystem for now, so someone
else can work on another part of the drivers if desired. There's about
18 results when doing:

grep -r "sizeof.*/.*sizeof" /path/to/kernel/source/drivers/net/

and I got a total of about 129 lines for the whole kernel source tree,
based on the git sources from Linus' tree yesterday. You're right ...
plenty of work to do :)
So, I might get started on that later today, else, I'll get a start on
it tomorrow.

-Aaron Cripps

P.S. is there a spot in the wiki pages/wherever that we would mention
that *this part* of the project is being worked on, just so that
multiple people aren't writing patches for this stuff?
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] looking for a project? (ARRAY_SIZE)

[Robert P. J. Day]

On Fri, 25 May 2007, Cripps wrote:

> P.S. is there a spot in the wiki pages/wherever that we would
> mention that *this part* of the project is being worked on, just so
> that multiple people aren't writing patches for this stuff?

just edit the wiki page and make a note somewhere on the page.  you'll
have to register for an account first.

rday
-- 
====================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
====================================
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] looking for a project? (ARRAY_SIZE)

[Cripps]

Done and Done :)
-Aaron Cripps

On 5/25/07, Robert P. J. Day <rpjday@mindspring.com> wrote:
> On Fri, 25 May 2007, Cripps wrote:
>
> > P.S. is there a spot in the wiki pages/wherever that we would
> > mention that *this part* of the project is being worked on, just so
> > that multiple people aren't writing patches for this stuff?
>
> just edit the wiki page and make a note somewhere on the page.  you'll
> have to register for an account first.
>
> rday
> --
> ====================================
> Robert P. J. Day
> Linux Consulting, Training and Annoying Kernel Pedantry
> Waterloo, Ontario, CANADA
>
> http://fsdev.net/wiki/index.php?title=Main_Page
> ====================================
>
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] looking for a project? (ARRAY_SIZE)

[Cripps]

No, By all means, grab a part and hack away, just don't forget to update the
"Claimed Tasks" section of the wiki, as mentioned earlier in this thread.
-Aaron Cripps
I moved this message over from the *other* thread for the benefit of
having a reference in the same thread ... and to keep it all in one :)

On 5/25/07, Andi Drebes <lists-receive@programmierforen.de> wrote:
> Hi!
>
> > Wow. That looks like one helluva project ... I'd like to undertake
> > starting this in the drivers/ subsystem ... I can't start on it right
> > now (because it's late), but I will have a few looks at it over the
> > weekend.
> <snip>
>
> I just had a look on that and I found quite a lot of places that have to be
> fixed. Currently, I'm inspecting and fixing files in drivers/block,
> drivers/atm and drivers/char. I also found suspicious lines in the arch
> directory. Do you prefer to do the whole thing on your own or would you like
> me to work there, too? I don't want to duplicate work, neither grab the
> project away.
>
>         Cheers,
>                 Andi
>
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] looking for a project? (ARRAY_SIZE)

[Andi Drebes]

Hi!

> No, By all means, grab a part and hack away, just don't forget to update
> the "Claimed Tasks" section of the wiki, as mentioned earlier in this
> thread.
OK. I think I can prepare my patches ("what I've got so far") tomorrow and 
send them directly to the mailing list. How do you propose the patches should 
be organized? One subdirectory of drivers per patch? One per module? Things 
might end up in too many patches or big patches that don't affect the same 
subsystem...

> I moved this message over from the *other* thread for the benefit of
> having a reference in the same thread ... and to keep it all in one :)
OK.

	Cheers,
		Andi
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] looking for a project? (ARRAY_SIZE)

[Cripps]

> OK. I think I can prepare my patches ("what I've got so far") tomorrow and
> send them directly to the mailing list. How do you propose the patches should
> be organized? One subdirectory of drivers per patch? One per module? Things
> might end up in too many patches or big patches that don't affect the same
> subsystem...
> OK.
>
>         Cheers,
>                 Andi

That would depend on filesize, I suppose. If a file has multiple
replacements/fixes then
you'll probably want to submit multiple patches per directory . If one
directory, say, has 100-200 lines for a patchfile, I'd say submit one
patch per directory, else submit per file. Just remember to follow the
conventions listed here:
http://kernelnewbies.org/UpstreamMerge/MergingStrategy

cheers,
-Aaron Cripps
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] looking for a project? (ARRAY_SIZE)

[Robert P. J. Day]

On Fri, 25 May 2007, Andi Drebes wrote:

> OK. I think I can prepare my patches ("what I've got so far")
> tomorrow and send them directly to the mailing list. How do you
> propose the patches should be organized? One subdirectory of drivers
> per patch? One per module? Things might end up in too many patches
> or big patches that don't affect the same subsystem...

if you can do a chunk at a time that is under the authority of a
single maintainer in the MAINTAINERS file, and Cc that maintainer each
time you post to the list, that's the easiest way to do it.

rday
-- 
====================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
====================================
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors