All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cfi_cmdset_0001.c: sparse fixes
@ 2007-05-28 19:11 Ben Dooks
  0 siblings, 0 replies; only message in thread
From: Ben Dooks @ 2007-05-28 19:11 UTC (permalink / raw)
  To: linux-mtd

Fix sparse warnings generated from cfi_cmdset_0001.c.

drivers/mtd/chips/cfi_cmdset_0001.c:1783:5: warning: symbol 'cfi_intelext_erase_varsize' was not declared. Should it be static?
drivers/mtd/chips/cfi_cmdset_0001.c:2258:43: warning: Using plain integer as NULL pointer

Signed-off-by: Ben Dooks <ben-linux@fluff.org>

--- linux-2.6.22-rc3/drivers/mtd/chips/cfi_cmdset_0001.c	2007-05-27 18:54:21.000000000 +0100
+++ linux-2.6.22-rc3-sparse1/drivers/mtd/chips/cfi_cmdset_0001.c	2007-05-28 20:09:26.000000000 +0100
@@ -1780,7 +1780,7 @@ static int __xipram do_erase_oneblock(st
 	return ret;
 }
 
-int cfi_intelext_erase_varsize(struct mtd_info *mtd, struct erase_info *instr)
+static int cfi_intelext_erase_varsize(struct mtd_info *mtd, struct erase_info *instr)
 {
 	unsigned long ofs, len;
 	int ret;
@@ -2255,7 +2255,7 @@ static void cfi_intelext_save_locks(stru
 			adr = region->offset + block * len;
 
 			status = cfi_varsize_frob(mtd,
-					do_getlockstatus_oneblock, adr, len, 0);
+					do_getlockstatus_oneblock, adr, len, NULL);
 			if (status)
 				set_bit(block, region->lockmap);
 			else

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-05-28 19:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-28 19:11 [PATCH] cfi_cmdset_0001.c: sparse fixes Ben Dooks

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.