All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-arm-kernel@lists.arm.linux.org.uk,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: ARM: Section mismatch warnings
Date: Mon, 28 May 2007 20:25:48 +0100	[thread overview]
Message-ID: <20070528192548.GD5737@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20070528183629.GA30821@uranus.ravnborg.org>

On Mon, May 28, 2007 at 08:36:29PM +0200, Sam Ravnborg wrote:
> > 
> > > o-arm-neponset/log.out:WARNING: arch/arm/mach-sa1100/built-in.o(.text+0x1748):
> >  Section mismatch: reference to .init.text:sa1110_mb_disable
> >  (between 'neponset_init' and 'neponset_resume')
> > 
> > This one looks quite bogus.  sa1110_mb_disable() is marked __init, and
> > it's called from neponset_init() which is also marked __init.
> 
> Created a neponset.i file - output:
> 
> static int neponset_init(void)
> {
>  platform_driver_register(&neponset_device_driver);
> 
> So we loose the __init marker during preprocessing.
> Which is due the the buggy part of my path that adds __devinit.
> 
> There was a reason I noted the devinit markers should be reviewed
> carefully - this one seems wrong.

I don't understand why you added that __devinit in the first place.
What happens if you leave it as a mere __init function, as it should be?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

  reply	other threads:[~2007-05-28 19:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-28 16:32 ARM: Section mismatch warnings Sam Ravnborg
2007-05-28 16:44 ` [PATCH] arm: fix section " Sam Ravnborg
2007-05-28 17:09   ` Russell King
2007-05-28 18:38     ` Sam Ravnborg
2007-05-28 17:04 ` ARM: Section " Russell King
2007-05-28 17:56   ` Andrew Victor
2007-05-28 18:36   ` Sam Ravnborg
2007-05-28 19:25     ` Russell King [this message]
2007-05-28 19:58       ` Sam Ravnborg
2007-05-28 20:25         ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070528192548.GD5737@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.