All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	ibm-acpi-devel@lists.sourceforge.net,
	Richard Hughes <hughsient@gmail.com>,
	linux-acpi@vger.kernel.org, linux-input@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h
Date: Wed, 30 May 2007 15:42:08 +0100	[thread overview]
Message-ID: <20070530144208.GA30351@srcf.ucam.org> (raw)
In-Reply-To: <d120d5000705300731p324fb5d4j6f800044b27b4388@mail.gmail.com>

On Wed, May 30, 2007 at 10:31:35AM -0400, Dmitry Torokhov wrote:

> Not all world is X :)  Actually few of "FN" keys, like KEY_WLAN,
> KEY_SLEEP, etc should be handled not [only] by X but by other layers.

I agree - the ones that have a defined function should certainly be set 
to sensible defaults, but I think the sensible default for a key without 
a defined function is "Key of undefined function" (like KEY_PROG*), not 
"Key which doesn't generate a keycode" :)

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2007-05-30 14:42 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-26 17:28 [RFC] thinkpad-acpi input hotkey events Henrique de Moraes Holschuh
     [not found] ` <11802004861625-git-send-email-hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
2007-05-26 17:31   ` [PATCH] ACPI: thinkpad-acpi: register input device Henrique de Moraes Holschuh
     [not found]     ` <11802006651698-git-send-email-hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
2007-05-26 17:31       ` [PATCH] ACPI: thinkpad-acpi: add input device support to hotkey subdriver Henrique de Moraes Holschuh
2007-05-26 17:31         ` [PATCH] ACPI: thinkpad-acpi: allow hotkey to input event map to be modified Henrique de Moraes Holschuh
2007-05-26 17:31           ` [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h Henrique de Moraes Holschuh
2007-05-27  3:40             ` Dmitry Torokhov
2007-05-27 12:15               ` Henrique de Moraes Holschuh
2007-05-27 18:10                 ` Henrique de Moraes Holschuh
     [not found]                 ` <20070527121513.GC19562-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-05-29  3:16                   ` Dmitry Torokhov
     [not found]                     ` <200705282316.32173.dtor-xOqKmqBdiMhF6kxbq+BtvQ@public.gmane.org>
2007-05-29 13:05                       ` Henrique de Moraes Holschuh
2007-05-30 13:57                         ` Dmitry Torokhov
2007-05-30 14:04                           ` Matthew Garrett
2007-05-30 14:18                             ` Dmitry Torokhov
2007-05-30 14:25                               ` Matthew Garrett
2007-05-30 14:31                                 ` Dmitry Torokhov
2007-05-30 14:42                                   ` Matthew Garrett [this message]
2007-05-30 15:07                               ` Henrique de Moraes Holschuh
2007-05-30 15:24                           ` Henrique de Moraes Holschuh
2007-05-30 16:04                             ` Dmitry Torokhov
2007-05-30 17:24                               ` Henrique de Moraes Holschuh
2007-05-30 20:25                                 ` Dmitry Torokhov
2007-05-30 23:01                                   ` [ibm-acpi-devel] " Matthew Garrett
2007-05-31  0:53                                   ` Making KEY_UNKNOWN really useful to userland Henrique de Moraes Holschuh
2007-05-31  4:33                                     ` Dmitry Torokhov
2007-05-31 22:28                                       ` [PATCH] Input: document the proper usage of EV_KEY and KEY_UNKNOWN Henrique de Moraes Holschuh
2007-05-31 23:33                                         ` Matthew Garrett
2007-06-01  0:13                                           ` Henrique de Moraes Holschuh
2007-06-01  0:24                                             ` Matthew Garrett
2007-06-01  1:29                                               ` Henrique de Moraes Holschuh
2007-06-01  1:44                                                 ` Matthew Garrett
2007-06-01  2:11                                                   ` Henrique de Moraes Holschuh
2007-06-01  3:33                                                   ` Dmitry Torokhov
2007-06-01  4:08                                                     ` Matthew Garrett
2007-06-01  4:37                                                       ` Dmitry Torokhov
2007-06-01 13:13                                                         ` Matthew Garrett
2007-06-01 14:04                                                           ` Dmitry Torokhov
2007-06-01 14:19                                                             ` Matthew Garrett
2007-06-01 15:06                                                             ` Henrique de Moraes Holschuh
2007-06-01 15:21                                                               ` Dmitry Torokhov
2007-06-01 14:51                                                           ` Henrique de Moraes Holschuh
2007-06-01 14:19                                                       ` Henrique de Moraes Holschuh
2007-06-20 10:21                                                         ` Helge Hafting
2007-06-06 16:55                                         ` [PATCH] Input: document the proper usage of EV_KEY and KEY_UNKNOWN (v2) Henrique de Moraes Holschuh
2007-06-29  5:04                                           ` Dmitry Torokhov
2007-06-30 18:20                                             ` Henrique de Moraes Holschuh
     [not found]                                     ` <20070531005305.GC6883-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-05-31 10:37                                       ` Making KEY_UNKNOWN really useful to userland Richard Hughes
2007-05-31 12:48                                         ` Henrique de Moraes Holschuh
2007-05-31 14:37                                           ` Dmitry Torokhov
2007-05-27  3:38           ` [PATCH] ACPI: thinkpad-acpi: allow hotkey to input event map to be modified Dmitry Torokhov
2007-05-27 12:03             ` Henrique de Moraes Holschuh
2007-05-29  3:08               ` Dmitry Torokhov
2007-05-29 12:46                 ` Henrique de Moraes Holschuh
     [not found]                   ` <20070529124639.GA12935-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-05-29 12:55                     ` Dmitry Torokhov
2007-05-29 13:06                       ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2007-05-27 18:07             ` Henrique de Moraes Holschuh
2007-05-27  3:35     ` [PATCH] ACPI: thinkpad-acpi: register input device Dmitry Torokhov
2007-05-27 11:53       ` Henrique de Moraes Holschuh
2007-05-26 17:36   ` [RFC] thinkpad-acpi input hotkey events Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070530144208.GA30351@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hmh@hmh.eng.br \
    --cc=hughsient@gmail.com \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.