* Re: [MIPS] Fix modpost warnings by making start_secondary __cpuinit
[not found] <S28573756AbXEaP7t/20070531155949Z+115@ftp.linux-mips.org>
@ 2007-06-01 16:30 ` Atsushi Nemoto
2007-06-01 17:40 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Atsushi Nemoto @ 2007-06-01 16:30 UTC (permalink / raw)
To: linux-mips; +Cc: ralf
On Thu, 31 May 2007 16:59:44 +0100, linux-mips@linux-mips.org wrote:
> WARNING: arch/mips/kernel/built-in.o(.text+0x9a58): Section mismatch: reference to .init.text:cpu_report (between 'start_secondary' and 'smp_prepare_boot_cpu')
Looking at arch/mips/kernel/smp.c, I suppose there should be much more
functions to be marked as __cpuinit. For example,
prom_init_secondary(), prom_smp_finish(), prom_smp_finish(),
prom_boot_secondary(), etc.
And then, smtc_init_secondary(), smtc_smp_finish(), etc. ...
---
Atsushi Nemoto
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [MIPS] Fix modpost warnings by making start_secondary __cpuinit
2007-06-01 16:30 ` [MIPS] Fix modpost warnings by making start_secondary __cpuinit Atsushi Nemoto
@ 2007-06-01 17:40 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2007-06-01 17:40 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: linux-mips
On Sat, Jun 02, 2007 at 01:30:22AM +0900, Atsushi Nemoto wrote:
> Looking at arch/mips/kernel/smp.c, I suppose there should be much more
> functions to be marked as __cpuinit. For example,
> prom_init_secondary(), prom_smp_finish(), prom_smp_finish(),
> prom_boot_secondary(), etc.
>
> And then, smtc_init_secondary(), smtc_smp_finish(), etc. ...
That is absolutely correct but beyond the minimal fix needed to deal with
the warning for 2.6.22. Longer term I'd like to get CPU hotplugging
working, it could be a handy feature with multi-threaded kernel models such
as VSMP and SMTC.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-06-01 17:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <S28573756AbXEaP7t/20070531155949Z+115@ftp.linux-mips.org>
2007-06-01 16:30 ` [MIPS] Fix modpost warnings by making start_secondary __cpuinit Atsushi Nemoto
2007-06-01 17:40 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.