From: Michael Buesch <mb@bu3sch.de>
To: James Ketrenos <jketreno@linux.intel.com>
Cc: Michael Wu <flamingice@sourmilk.net>, Jiri Benc <jbenc@suse.cz>,
John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Update stop_queues kdoc
Date: Fri, 1 Jun 2007 22:41:04 +0200 [thread overview]
Message-ID: <200706012241.05103.mb@bu3sch.de> (raw)
In-Reply-To: <46605814.1090806@linux.intel.com>
On Friday 01 June 2007 19:32:04 James Ketrenos wrote:
> iwlwifi currently calls ieee80211_stop_queue from the Tx handler and calls ieee80211_stop_queues in the event the adapter is reset (due to HW error, RF kill transition, hw tear down, etc.) as it asynchronously brings re-initializes the hardware.
I think we do that in bcm43xx, too, and I think it is
indeed racy, too. So it may trigger the freeze, too.
A workaround might be to aquire the netdev_tx_lock around
the stop_queues call. But I'm not sure.
--
Greetings Michael.
next prev parent reply other threads:[~2007-06-01 20:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 9:29 [PATCH] mac80211: Update stop_queues kdoc Michael Buesch
2007-06-01 9:48 ` Johannes Berg
2007-06-01 9:53 ` Michael Buesch
2007-06-01 11:55 ` Olivier Cornu
2007-06-01 20:42 ` Michael Buesch
2007-06-01 21:00 ` Olivier Cornu
2007-06-01 21:42 ` Michael Buesch
2007-06-01 21:53 ` Olivier Cornu
2007-06-02 13:17 ` Olivier Cornu
2007-06-02 13:37 ` Michael Buesch
2007-06-02 18:41 ` Olivier Cornu
2007-06-01 16:58 ` James Ketrenos
2007-06-01 19:04 ` Michael Wu
2007-06-01 17:32 ` James Ketrenos
2007-06-01 20:36 ` Michael Wu
2007-06-01 20:52 ` Michael Buesch
2007-06-01 20:41 ` Michael Buesch [this message]
2007-06-01 20:52 ` Olivier Cornu
2007-06-01 20:54 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706012241.05103.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=jketreno@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.