Re: PATCH: Add persistent guest & hv logging in xenconsoled

["Daniel P. Berrange" <berrange@redhat.com>]

On Mon, Jun 04, 2007 at 02:48:25PM +0100, Keir Fraser wrote:
> On 31/5/07 22:32, "Daniel P. Berrange" <berrange@redhat.com> wrote:
> 
> >   * Adds a --pid-file command line argument to override the default
> >     location of pid file (this is not really related to logging, but
> >     since i was in that code...)
> 
> Applied, thanks. But...
> 
> Use of uninitialised local variable pidfile detected by gcc in this patch.
> You guys really should consider using -Werror. It's great. :-)

Opps, we do use -Werror for all formal builds - dunno how that got missed.

> Also, shouldn't the writes to log files be non-blocking, and those fds be
> added to the select set when there is data waiting to be written?

IIRC, if you select() on a local file handle it'll always be shown writable
so I don't believe it'll be any use.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|