From: Keir Fraser <keir@xensource.com>
To: "Daniel P. Berrange" <berrange@redhat.com>,
xen-devel@lists.xensource.com
Subject: Re: PATCH: Add persistent guest & hv logging in xenconsoled
Date: Mon, 04 Jun 2007 14:48:25 +0100 [thread overview]
Message-ID: <C289D6B9.FF30%keir@xensource.com> (raw)
In-Reply-To: <20070531213208.GD15661@redhat.com>
On 31/5/07 22:32, "Daniel P. Berrange" <berrange@redhat.com> wrote:
> * Adds a --pid-file command line argument to override the default
> location of pid file (this is not really related to logging, but
> since i was in that code...)
Applied, thanks. But...
Use of uninitialised local variable pidfile detected by gcc in this patch.
You guys really should consider using -Werror. It's great. :-)
Also, shouldn't the writes to log files be non-blocking, and those fds be
added to the select set when there is data waiting to be written?
-- Keir
next prev parent reply other threads:[~2007-06-04 13:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-31 21:32 PATCH: Add persistent guest & hv logging in xenconsoled Daniel P. Berrange
2007-06-01 8:10 ` Keir Fraser
2007-06-01 13:51 ` Daniel P. Berrange
2007-06-01 14:17 ` Keir Fraser
2007-06-04 13:48 ` Keir Fraser [this message]
2007-06-04 13:52 ` Daniel P. Berrange
2007-06-04 14:07 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C289D6B9.FF30%keir@xensource.com \
--to=keir@xensource.com \
--cc=berrange@redhat.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.