several patches to mlmmj

several patches to mlmmj

[Ansgar Burchardt]

Hi!

I started using mlmmj for two small mailinglists.  Because some things bothered
me I wrote several patches:
 * At two placed exit() isn't called in case the exec() fails.
 * The German listtexts uses the ISO-8859-1 charset, but doesn't say so in
   the headers.  I added a Content-Type and Content-Encoding header.
 * RFC 2882 recommends using the domain name in the right hand side of the
   Message-Id header.
 * The English listtexts were moved into subdirectory, similar to the
   translated listtexts.  Also I changed mlmmj-make-ml.sh:  the path to the
   listtexts can now be relative.  This makes choosing between the provided
   translations easier.
 * remove a superfluous concatstr() in genmsgid()
 * the paths to the various mlmmj-* programs are already known at build time,
   so why not use this information?  This way the programs do no longer have to
   be called with /full/path/to/mlmmj-*.  Also use sed to substitute things in
   mlmmj-make-ml.sh.in (the autoconf manual recommends doing so, and it is
   required for this change).

My changes are in my mercurial repository at http://hg.43-1.org/mlmmj.  It
would be nice, if they can be included in mlmmj.

Regards,
Ansgar

Re: several patches to mlmmj

[Mads Martin Joergensen]

* Ansgar Burchardt <ansgar@2007.43-1.org> [Jun 06. 2007 23:49]:
> Hi!
> 
> I started using mlmmj for two small mailinglists.  Because some things bothered
> me I wrote several patches:
>  * At two placed exit() isn't called in case the exec() fails.
>  * The German listtexts uses the ISO-8859-1 charset, but doesn't say so in
>    the headers.  I added a Content-Type and Content-Encoding header.
>  * RFC 2882 recommends using the domain name in the right hand side of the
>    Message-Id header.
>  * The English listtexts were moved into subdirectory, similar to the
>    translated listtexts.  Also I changed mlmmj-make-ml.sh:  the path to the
>    listtexts can now be relative.  This makes choosing between the provided
>    translations easier.
>  * remove a superfluous concatstr() in genmsgid()

These sounds fine! I would like to review them.

>  * the paths to the various mlmmj-* programs are already known at
>  build time, so why not use this information?  This way the programs
>  do no longer have to be called with /full/path/to/mlmmj-*.  Also use
>  sed to substitute things in mlmmj-make-ml.sh.in (the autoconf manual
>  recommends doing so, and it is required for this change).

They might not be known at build time, and they might be moved around.
By doing this and not requiring full path you remove the flexibility one
has in moving the binaries later on. Say I'm upgrading to the new one
for some lists, but I decide to move the old ones to
/usr/local/bin/mlmmj-old/ and keep the new ones where the old ones were
in /usr/local/bin. Then you cannot switch the entire list to the old
corresponding tools by just changing how it's called.

> My changes are in my mercurial repository at http://hg.43-1.org/mlmmj.  It
> would be nice, if they can be included in mlmmj.

We would very much like to do so, would you mind sending a unified diff
with the changes?

-- 
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                 -- A. P. J.

Re: several patches to mlmmj

[Mads Martin Joergensen]

* Mads Martin Joergensen <mmj@mmj.dk> [Jun 07. 2007 01:19]:
> > My changes are in my mercurial repository at http://hg.43-1.org/mlmmj.  It
> > would be nice, if they can be included in mlmmj.
> 
> We would very much like to do so, would you mind sending a unified diff
> with the changes?

No need to. Just browsed the page--mercurial is really nice :-)

-- 
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                 -- A. P. J.

Re: several patches to mlmmj

[Ansgar Burchardt]

Hi!

Mads Martin Joergensen wrote:
> * Ansgar Burchardt <ansgar@2007.43-1.org> [Jun 06. 2007 23:49]:
> >  * the paths to the various mlmmj-* programs are already known at
> >  build time, so why not use this information?  This way the programs
> >  do no longer have to be called with /full/path/to/mlmmj-*.  Also use
> >  sed to substitute things in mlmmj-make-ml.sh.in (the autoconf manual
> >  recommends doing so, and it is required for this change).
> 
> They might not be known at build time, and they might be moved around.
> By doing this and not requiring full path you remove the flexibility one
> has in moving the binaries later on.

Ok, I undid this change.

> > My changes are in my mercurial repository at http://hg.43-1.org/mlmmj.  It
> > would be nice, if they can be included in mlmmj.
> 
> We would very much like to do so, would you mind sending a unified diff
> with the changes?

I put together a diff at http://43-1.org/tmp/mlmmj.diff.  It should be a bit
cleaner than the diffs in the repository as I didn't include the Makefile.in
diffs.
After applying the patch, you should run autoconf/automake as I changed
configure.ac.

Regards,
Ansgar

Re: several patches to mlmmj

[Morten K. Poulsen]

Hi Ansgar,

Ansgar Burchardt <ansgar@2007.43-1.org> wrote:
> I started using mlmmj for two small mailinglists.  Because
> some things bothered me I wrote several patches:

Oh, I love that kind of users. "This and that didn't work, so
I fixed it." :-)

[snip]
> My changes are in my mercurial repository at http://hg.43-1.org/mlmmj.
> It would be nice, if they can be included in mlmmj.

I will review your changes, and commit them ASAP. It will probably be
in the weekend.

Morten

-- 
Morten K. Poulsen <morten@afdelingp.dk>
http://www.afdelingp.dk/