From: "Jose R. Santos" <jrs@us.ibm.com>
To: Andreas Dilger <adilger@clusterfs.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] JBD2: Change debug file path
Date: Fri, 8 Jun 2007 07:01:47 -0500 [thread overview]
Message-ID: <20070608070147.7e021685@gara> (raw)
In-Reply-To: <20070608070812.GE5181@schatzie.adilger.int>
On Fri, 8 Jun 2007 01:08:12 -0600
Andreas Dilger <adilger@clusterfs.com> wrote:
> On Jun 07, 2007 23:45 -0500, Jose R. Santos wrote:
> > The jbd2-debug file used to be located in /proc/sys/fs/jbd2-debug, but
> > create_proc_entry() does not do lookups on file names with more that one
> > directory deep. This causes the entry creation to fail and hence, no proc
> > file is created. This patch moves the file to /proc/jbd2-degug.
> >
> > The file could be move to /proc/fs/jbd2/jbd2-debug, but it would require
> > some minor alterations to the jbd-stats patch.
>
> I don't think we really want to be adding top-level files in /proc.
> What about using the "debugfs" filesystem (not to be confused with
> the e2fsprogs 'debugfs' command)?
I agree. Was feeling kind of lazy though and didn't want to to much
time on this issue. :)
I'll look into changing jbd and jbd2 into using debugfs.
-JRS
next prev parent reply other threads:[~2007-06-08 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 4:45 [PATCH] JBD2: Change debug file path Jose R. Santos
2007-06-08 7:08 ` Andreas Dilger
2007-06-08 12:01 ` Jose R. Santos [this message]
2007-06-09 3:57 ` [PATCH][RFC] JBD2: Use DebugFS for jbd2 debug config option Jose R. Santos
2007-06-11 22:04 ` Mingming Cao
2007-06-11 22:22 ` Jose R. Santos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070608070147.7e021685@gara \
--to=jrs@us.ibm.com \
--cc=adilger@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.