Re: [PATCH][RFC] JBD2: Use DebugFS for jbd2 debug config option.

["Jose R. Santos" <jrs@us.ibm.com>]

On Mon, 11 Jun 2007 15:04:42 -0700
Mingming Cao <cmm@us.ibm.com> wrote:

> On Fri, 2007-06-08 at 22:57 -0500, Jose R. Santos wrote:
> > On Fri, 8 Jun 2007 01:08:12 -0600
> > Andreas Dilger <adilger@clusterfs.com> wrote:
> > 
> > > On Jun 07, 2007  23:45 -0500, Jose R. Santos wrote:
> > > > The jbd2-debug file used to be located in /proc/sys/fs/jbd2-debug, but
> > > > create_proc_entry() does not do lookups on file names with more that one
> > > > directory deep.  This causes the entry creation to fail and hence, no proc
> > > > file is created.  This patch moves the file to /proc/jbd2-degug.
> > > > 
> > > > The file could be move to /proc/fs/jbd2/jbd2-debug, but it would require
> > > > some minor alterations to the jbd-stats patch.
> > > 
> > > I don't think we really want to be adding top-level files in /proc.
> > > What about using the "debugfs" filesystem (not to be confused with
> > > the e2fsprogs 'debugfs' command)?
> > 
> > How about this then?  Moved the file to use debugfs as well as having
> > the nice effect of removing more lines than what it adds.
> > 
> Shall we do this for ext3 as well?

We should since its broken in the old JBD code as well.  I'll make a
patch and post it to fsdevel and LKML.

-JRS