[PATCH 6/6] mac80211: Fix one more sparse error

[PATCH 6/6] mac80211: Fix one more sparse error

[Zhu Yi]

Fix one more sparse error and comment variable for debugfs_rename TODO.

Signed-off-by: Zhu Yi <yi.zhu@intel.com>
---
 net/mac80211/debugfs_netdev.c |    2 ++
 net/mac80211/debugfs_sta.c    |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/net/mac80211/debugfs_netdev.c b/net/mac80211/debugfs_netdev.c
index 5e50817..52a32e4 100644
--- a/net/mac80211/debugfs_netdev.c
+++ b/net/mac80211/debugfs_netdev.c
@@ -734,7 +734,9 @@ static int netdev_notify(struct notifier_block * nb,
 			 void *ndev)
 {
 	struct net_device *dev = ndev;
+	/* TODO
 	char buf[10+IFNAMSIZ];
+	*/
 
 	if (state != NETDEV_CHANGENAME)
 		return 0;
diff --git a/net/mac80211/debugfs_sta.c b/net/mac80211/debugfs_sta.c
index fc1a024..6cfe35a 100644
--- a/net/mac80211/debugfs_sta.c
+++ b/net/mac80211/debugfs_sta.c
@@ -158,7 +158,7 @@ static ssize_t sta_last_seq_ctrl_read(struct file *file, char __user *userbuf,
 	struct sta_info *sta = file->private_data;
 	for (i = 0; i < NUM_RX_DATA_QUEUES; i++)
 		p += scnprintf(p, sizeof(buf)+buf-p, "%x ",
-			       sta->last_seq_ctrl[i]);
+			       le16_to_cpu(sta->last_seq_ctrl[i]));
 	p += scnprintf(p, sizeof(buf)+buf-p, "\n");
 	return simple_read_from_buffer(userbuf, count, ppos, buf, p - buf);
 }
-- 
1.5.0.rc2.g73a2

Re: [PATCH 6/6] mac80211: Fix one more sparse error

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

On Sat, 2007-06-09 at 01:04 +0800, Zhu Yi wrote:
> Fix one more sparse error and comment variable for debugfs_rename TODO.

> @@ -734,7 +734,9 @@ static int netdev_notify(struct notifier_block * nb,
>  			 void *ndev)
>  {
>  	struct net_device *dev = ndev;
> +	/* TODO
>  	char buf[10+IFNAMSIZ];
> +	*/

Heh, I actually left that intentionally, but yeah, I guess it's fine.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]