From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Update for NTFS file system driver
Date: Sun, 10 Jun 2007 17:15:53 +0200 [thread overview]
Message-ID: <20070610151553.GA2640@aragorn> (raw)
In-Reply-To: <20070610120329.GA782@ws3.vdp.com>
[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]
I noticed that your patch isn't adding ntfs to the utils (grub-probe, etc).
I'm attaching a fix for that. ChangeLog entries:
* conf/powerpc-ieee1275.rmk: Add fs/ntfs.c to grub-probe and grub-emu.
* conf/i386-efi.rmk: Likewise. Also remove unused grub-setup definition.
* conf/i386-pc.rmk: Add fs/ntfs.c to grub-probe, grub-emu and
grub-setup.
On Sun, Jun 10, 2007 at 08:03:29PM +0800, Bean wrote:
> Ok, I reformat the patch, hopefully it will conform to standard.
I think what Marco meant is a multipart/mixed attachment (like the one I'm
sending now). This is what most mail programs do when you attach a text file
(but not a gzipped one!).
The good thing about this method, is that you can easily extract a patch
(without copy-pasting or being exposed to unwanted format conversions), but
the patch is still part of the message so you can reply to it to discuss
specific parts, keeping their context.
--
Robert Millan
My spam trap is honeypot@aybabtu.com. Note: this address is only intended
for spam harvesters. Writing to it will get you added to my black list.
[-- Attachment #2: add_ntfs_to_utils.diff --]
[-- Type: text/x-diff, Size: 3933 bytes --]
* conf/powerpc-ieee1275.rmk: Add fs/ntfs.c to grub-probe and grub-emu.
* conf/i386-efi.rmk: Likewise. Also remove unused grub-setup definition.
* conf/i386-pc.rmk: Add fs/ntfs.c to grub-probe, grub-emu and
grub-setup.
diff -ur grub2.old/conf/i386-efi.rmk grub2/conf/i386-efi.rmk
--- grub2.old/conf/i386-efi.rmk 2007-06-04 21:48:53.000000000 +0200
+++ grub2/conf/i386-efi.rmk 2007-06-10 17:03:39.000000000 +0200
@@ -15,14 +15,6 @@
grub_mkimage_SOURCES = util/i386/efi/grub-mkimage.c util/misc.c \
util/resolve.c
-# For grub-setup.
-#grub_setup_SOURCES = util/i386/pc/grub-setup.c util/i386/pc/biosdisk.c \
-# util/misc.c util/i386/pc/getroot.c kern/device.c kern/disk.c \
-# kern/err.c kern/misc.c fs/fat.c fs/ext2.c fs/xfs.c fs/affs.c \
-# fs/sfs.c kern/parser.c kern/partition.c partmap/pc.c \
-# fs/ufs.c fs/minix.c fs/hfs.c fs/jfs.c fs/hfsplus.c kern/file.c \
-# kern/fs.c kern/env.c fs/fshelp.c
-
# For grub-mkdevicemap.
grub_mkdevicemap_SOURCES = util/grub-mkdevicemap.c util/misc.c
@@ -32,7 +24,7 @@
kern/device.c kern/disk.c kern/err.c kern/misc.c fs/fat.c \
fs/ext2.c kern/parser.c kern/partition.c \
partmap/pc.c partmap/apple.c partmap/gpt.c \
- fs/ufs.c fs/minix.c fs/hfs.c fs/jfs.c kern/fs.c \
+ fs/ufs.c fs/minix.c fs/hfs.c fs/jfs.c fs/ntfs.c kern/fs.c \
kern/env.c fs/fshelp.c fs/xfs.c fs/affs.c fs/sfs.c fs/hfsplus.c \
disk/lvm.c disk/raid.c
@@ -48,6 +40,7 @@
disk/loopback.c \
fs/affs.c fs/ext2.c fs/fat.c fs/fshelp.c fs/hfs.c fs/iso9660.c \
fs/jfs.c fs/minix.c fs/sfs.c fs/ufs.c fs/xfs.c fs/hfsplus.c \
+ fs/ntfs.c \
io/gzio.c \
kern/device.c kern/disk.c kern/dl.c kern/elf.c kern/env.c \
kern/err.c \
diff -ur grub2.old/conf/i386-pc.rmk grub2/conf/i386-pc.rmk
--- grub2.old/conf/i386-pc.rmk 2007-06-04 21:48:53.000000000 +0200
+++ grub2/conf/i386-pc.rmk 2007-06-10 17:02:38.000000000 +0200
@@ -67,7 +67,8 @@
kern/err.c kern/misc.c fs/fat.c fs/ext2.c fs/xfs.c fs/affs.c \
fs/sfs.c kern/parser.c kern/partition.c partmap/pc.c \
partmap/gpt.c fs/ufs.c fs/minix.c fs/hfs.c fs/jfs.c \
- fs/hfsplus.c kern/file.c kern/fs.c kern/env.c fs/fshelp.c \
+ fs/hfsplus.c fs/ntfs.c kern/file.c kern/fs.c kern/env.c \
+ fs/fshelp.c \
util/raid.c util/lvm.c
# For grub-mkdevicemap.
@@ -79,7 +80,7 @@
kern/device.c kern/disk.c kern/err.c kern/misc.c fs/fat.c \
fs/ext2.c kern/parser.c kern/partition.c \
partmap/pc.c partmap/apple.c partmap/gpt.c \
- fs/ufs.c fs/minix.c fs/hfs.c fs/jfs.c kern/fs.c \
+ fs/ufs.c fs/minix.c fs/hfs.c fs/jfs.c fs/ntfs.c kern/fs.c \
kern/env.c fs/fshelp.c fs/xfs.c fs/affs.c fs/sfs.c fs/hfsplus.c \
disk/lvm.c disk/raid.c
@@ -95,6 +96,7 @@
disk/loopback.c disk/raid.c disk/lvm.c \
fs/affs.c fs/ext2.c fs/fat.c fs/fshelp.c fs/hfs.c fs/iso9660.c \
fs/jfs.c fs/minix.c fs/sfs.c fs/ufs.c fs/xfs.c fs/hfsplus.c \
+ fs/ntfs.c \
io/gzio.c \
kern/device.c kern/disk.c kern/dl.c kern/elf.c kern/env.c \
kern/err.c \
diff -ur grub2.old/conf/powerpc-ieee1275.rmk grub2/conf/powerpc-ieee1275.rmk
--- grub2.old/conf/powerpc-ieee1275.rmk 2007-06-04 21:48:53.000000000 +0200
+++ grub2/conf/powerpc-ieee1275.rmk 2007-06-10 17:04:01.000000000 +0200
@@ -44,7 +44,7 @@
kern/device.c kern/disk.c kern/err.c kern/misc.c fs/fat.c \
fs/ext2.c kern/parser.c kern/partition.c \
partmap/pc.c partmap/apple.c partmap/gpt.c \
- fs/ufs.c fs/minix.c fs/hfs.c fs/jfs.c kern/fs.c \
+ fs/ufs.c fs/minix.c fs/hfs.c fs/jfs.c fs/ntfs.c kern/fs.c \
kern/env.c fs/fshelp.c fs/xfs.c fs/affs.c fs/sfs.c fs/hfsplus.c \
disk/lvm.c disk/raid.c
@@ -59,6 +59,7 @@
disk/loopback.c \
fs/affs.c fs/ext2.c fs/fat.c fs/fshelp.c fs/hfs.c fs/iso9660.c \
fs/jfs.c fs/minix.c fs/sfs.c fs/ufs.c fs/xfs.c fs/hfsplus.c \
+ fs/ntfs.c \
io/gzio.c \
kern/device.c kern/disk.c kern/dl.c kern/elf.c kern/env.c \
kern/err.c kern/file.c kern/fs.c kern/loader.c kern/main.c \
next prev parent reply other threads:[~2007-06-10 15:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-09 4:56 Update for NTFS file system driver Bean
2007-06-09 18:05 ` Marco Gerards
2007-06-10 3:42 ` Bean
2007-06-10 7:57 ` Marco Gerards
2007-06-10 9:19 ` Thomas Schwinge
2007-06-10 9:55 ` Marco Gerards
2007-06-10 12:03 ` Bean
2007-06-10 15:15 ` Robert Millan [this message]
2007-06-10 15:29 ` Marco Gerards
2007-06-10 16:36 ` Bean
2007-06-13 18:27 ` Marco Gerards
2007-06-10 10:18 ` history of fsys_ntfs.c (Re: Update for NTFS file system driver) Robert Millan
2007-06-10 10:52 ` Bean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070610151553.GA2640@aragorn \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.