All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Drebes <lists-receive@programmierforen.de>
To: Darren Jenkins <darrenrjenkins@gmail.com>
Cc: Jan-Benedict Glaw <jbglaw@lug-owl.de>,
	kernel-janitors@lists.osdl.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Karsten Keil <kkeil@suse.de>
Subject: Re: [KJ] Re: [PATCH] drivers/isdn/hisax: ARRAY_SIZE instead of sizeof
Date: Mon, 11 Jun 2007 18:51:11 +0000	[thread overview]
Message-ID: <200706112051.12407.lists-receive@programmierforen.de> (raw)
In-Reply-To: <82faac5b0706110525s56bade43rb24619b54687770d@mail.gmail.com>

<snip>
> I think what was meant here was to remove _all_ the macros that you
> assigned to the ARRAY_SIZE() macro.
Yes, absolutely. I overlooked the 'eg.' in Jan-Benedict's post. Sorry for that.

> If you look at the two advantages replacing code with the ARRAY_SIZE()
> macro has;
> 1. More readable/consistent code.
> 2. Faster compile times, because of less macros being defined.
ack. The arguments for the consistency that I mentioned in my last post
don't hold for a solution that removes all of the macros. So I'm absolutely
fine with a new patch that removes them all.
 
	Andi
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Andi Drebes <lists-receive@programmierforen.de>
To: "Darren Jenkins" <darrenrjenkins@gmail.com>
Cc: "Jan-Benedict Glaw" <jbglaw@lug-owl.de>,
	kernel-janitors@lists.osdl.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"Karsten Keil" <kkeil@suse.de>
Subject: Re: [KJ] Re: [PATCH] drivers/isdn/hisax: ARRAY_SIZE instead of sizeof
Date: Mon, 11 Jun 2007 20:51:11 +0200	[thread overview]
Message-ID: <200706112051.12407.lists-receive@programmierforen.de> (raw)
In-Reply-To: <82faac5b0706110525s56bade43rb24619b54687770d@mail.gmail.com>

<snip>
> I think what was meant here was to remove _all_ the macros that you
> assigned to the ARRAY_SIZE() macro.
Yes, absolutely. I overlooked the 'eg.' in Jan-Benedict's post. Sorry for that.

> If you look at the two advantages replacing code with the ARRAY_SIZE()
> macro has;
> 1. More readable/consistent code.
> 2. Faster compile times, because of less macros being defined.
ack. The arguments for the consistency that I mentioned in my last post
don't hold for a solution that removes all of the macros. So I'm absolutely
fine with a new patch that removes them all.
 
	Andi

  parent reply	other threads:[~2007-06-11 18:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-10 10:35 [KJ] [PATCH] drivers/isdn/hisax: ARRAY_SIZE instead of sizeof Andi Drebes
2007-06-10 10:35 ` Andi Drebes
2007-06-10 13:11 ` [KJ] " Karsten Keil
2007-06-10 13:11   ` Karsten Keil
2007-06-10 13:14   ` [KJ] " Jan-Benedict Glaw
2007-06-10 13:14     ` Jan-Benedict Glaw
2007-06-11  9:20     ` [KJ] " Andi Drebes
2007-06-11  9:20       ` Andi Drebes
2007-06-11 12:25       ` [KJ] " Darren Jenkins
2007-06-11 12:25         ` Darren Jenkins
2007-06-11 17:47         ` Karsten Keil
2007-06-11 17:47           ` Karsten Keil
2007-06-11 18:53           ` Andi Drebes
2007-06-11 18:53             ` Andi Drebes
2007-06-11 18:59           ` Jan-Benedict Glaw
2007-06-11 18:59             ` Jan-Benedict Glaw
2007-06-11 18:51         ` Andi Drebes [this message]
2007-06-11 18:51           ` Andi Drebes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706112051.12407.lists-receive@programmierforen.de \
    --to=lists-receive@programmierforen.de \
    --cc=darrenrjenkins@gmail.com \
    --cc=jbglaw@lug-owl.de \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=kkeil@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.