[Drbd-dev] drbd0: [drbd0_receiver/5740] sock_sendmsg time expired, ko = 4294967294

[Drbd-dev] drbd0: [drbd0_receiver/5740] sock_sendmsg time expired, ko = 4294967294

[Montrose, Ernest]

[-- Attachment #1: Type: text/plain, Size: 880 bytes --]

Hi all,
It seems that the mdev->ko_count counter is going negative as evidenced by the following message:
drbd0: [drbd0_receiver/5740] sock_sendmsg time expired, ko = 4294967294
 
Note the rather large ko value.
 STATIC we_should_drop_the_connection(drbd_dev *mdev, struct socket *sock) is the place we decrement this unconditionnaly. Should at least be this:
Index: drbd/drbd_main.c
===================================================================
--- drbd/drbd_main.c    (revision 14981)
+++ drbd/drbd_main.c    (working copy)
@@ -1549,7 +1549,7 @@
        if (drop_it)
                return TRUE;
-       drop_it = !--mdev->ko_count;
+       drop_it = !mdev->ko_count || !--mdev->ko_count;
        if ( !drop_it ) {
                ERR("[%s/%d] sock_sendmsg time expired, ko = %u\n",
                       current->comm, current->pid, mdev->ko_count);


[-- Attachment #2: Type: text/html, Size: 1734 bytes --]

Re: [Drbd-dev] drbd0: [drbd0_receiver/5740] sock_sendmsg time expired, ko = 4294967294

[Philipp Reisner]

On Monday 11 June 2007 03:39:47 Montrose, Ernest wrote:
> Hi all,
> It seems that the mdev->ko_count counter is going negative as evidenced by
> the following message: drbd0: [drbd0_receiver/5740] sock_sendmsg time
> expired, ko = 4294967294
>

This is intended this way. If you configure ko_count to zero it becomes
that very large integer with the first expiration of the timeout. I.e.
no drop of connection.

-Phil
-- 
: Dipl-Ing Philipp Reisner                      Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH          Fax +43-1-8178292-82 :
: Vivenotgasse 48, 1120 Vienna, Austria        http://www.linbit.com :

RE: [Drbd-dev] drbd0: [drbd0_receiver/5740] sock_sendmsg time expired, ko = 4294967294

[Montrose, Ernest]

Phil,
OK..So it's a feature..Not a bug..:)  Thanks for the clarification..

EM--

-----Original Message-----
From: drbd-dev-bounces@linbit.com [mailto:drbd-dev-bounces@linbit.com]
On Behalf Of Philipp Reisner
Sent: Tuesday, June 12, 2007 10:15 AM
To: drbd-dev@linbit.com
Subject: Re: [Drbd-dev] drbd0: [drbd0_receiver/5740] sock_sendmsg time
expired,ko = 4294967294

On Monday 11 June 2007 03:39:47 Montrose, Ernest wrote:
> Hi all,
> It seems that the mdev->ko_count counter is going negative as
evidenced by
> the following message: drbd0: [drbd0_receiver/5740] sock_sendmsg time
> expired, ko = 4294967294
>

This is intended this way. If you configure ko_count to zero it becomes
that very large integer with the first expiration of the timeout. I.e.
no drop of connection.

-Phil
-- 
: Dipl-Ing Philipp Reisner                      Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH          Fax +43-1-8178292-82 :
: Vivenotgasse 48, 1120 Vienna, Austria        http://www.linbit.com :
_______________________________________________
drbd-dev mailing list
drbd-dev@lists.linbit.com
http://lists.linbit.com/mailman/listinfo/drbd-dev