From: Dave Jones <davej@redhat.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Fix empty macros in acpi.
Date: Tue, 12 Jun 2007 20:21:15 -0400 [thread overview]
Message-ID: <20070613002115.GA28778@redhat.com> (raw)
In-Reply-To: <20070613000029.GK21478@ftp.linux.org.uk>
On Wed, Jun 13, 2007 at 01:00:29AM +0100, Al Viro wrote:
> On Tue, Jun 12, 2007 at 07:33:09PM -0400, Dave Jones wrote:
> > +#define DBG(x...) do { } while(0)
>
> Eh... Please, stop it - if you want a function-call-like no-op returning void,
> use ((void)0). At least that way one can say DBG(....),foo(), etc.
They both end up compiled to nothing anyway, so I'm not bothered
either way.. I'm not sure I follow why the syntax of that last part
is a good thing. It looks like something we'd want to avoid rather
than promote?
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-06-13 0:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-12 23:33 Fix empty macros in acpi Dave Jones
2007-06-13 0:00 ` Al Viro
2007-06-13 0:21 ` Dave Jones [this message]
2007-06-13 0:26 ` Al Viro
2007-07-03 5:22 ` Len Brown
2007-07-03 5:44 ` Dave Jones
2007-07-22 4:55 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070613002115.GA28778@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.