From: Dave Jones <davej@redhat.com>
To: Len Brown <lenb@kernel.org>
Cc: Al Viro <viro@ftp.linux.org.uk>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Fix empty macros in acpi.
Date: Tue, 3 Jul 2007 01:44:55 -0400 [thread overview]
Message-ID: <20070703054455.GB32110@redhat.com> (raw)
In-Reply-To: <200707030122.47747.lenb@kernel.org>
On Tue, Jul 03, 2007 at 01:22:47AM -0400, Len Brown wrote:
> whelp, it seems that the reason for this patch is this:
>
> #define DBG()
>
> if(...)
> DBG();
> next_c_statement
>
> which turns into
> if(...) ;
> next_c_statement
>
> But since there is an intervening ';', this code is still functionally correct
> and a decent compiler will delete the test altogether, yes?
Right, gcc does generate the correct code.
> So is there some real problem here that I missed,
> or is this to make some code-checking tool that I don't have happy?
Out of curiousity, I thought I'd see what was lurking in a -Wextra
build a while back. It's 99.9% noise, but a lot of it is trivial stuff
like this.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-07-03 5:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-12 23:33 Fix empty macros in acpi Dave Jones
2007-06-13 0:00 ` Al Viro
2007-06-13 0:21 ` Dave Jones
2007-06-13 0:26 ` Al Viro
2007-07-03 5:22 ` Len Brown
2007-07-03 5:44 ` Dave Jones [this message]
2007-07-22 4:55 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070703054455.GB32110@redhat.com \
--to=davej@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.