All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Ryan Riley <rileyrd@gmail.com>
Subject: Re: [Qemu-devel] CPUTLBEntry Question
Date: Thu, 14 Jun 2007 14:22:12 +0100	[thread overview]
Message-ID: <200706141422.13852.paul@codesourcery.com> (raw)
In-Reply-To: <812074ac0706131325t578dfd5eiaa5836b160a24679@mail.gmail.com>

> then QEMU crashes on startup.  (It also crashes if I put that blah
> entry on the beginning instead of the end.)  I'm sure there's code
> somewhere that must be making assumptions about the size of TLB entry,
> but I'm at a loss for finding it.  (I have noticed that the assembly
> code in softmmu_header.h indexes to the addend based on addr_read or
> addr_write, but adding a new member to the end of the structure
> shouldn't impact that, right?)

Wrong. The assembly implementation assumes CPUTLBEntry is 16 bytes (or to be 
exact 1 << CPU_TLB_ENTRY_BITS).

The C implementation in softmmu_header.h will work with any layout.

Paul

  reply	other threads:[~2007-06-14 13:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-13 20:25 [Qemu-devel] CPUTLBEntry Question Ryan Riley
2007-06-14 13:22 ` Paul Brook [this message]
2007-06-14 19:31   ` Ryan Riley
2007-06-14 13:41 ` amateur
2007-06-14 14:00   ` Blue Swirl
2007-06-15  1:47     ` amateur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706141422.13852.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rileyrd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.