All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Paulo Marques <pmarques@grupopie.com>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Mike Frysinger <vapier@gentoo.org>
Subject: Re: [PATCH] remove usage of memmem from scripts/kallsyms.c
Date: Tue, 19 Jun 2007 20:04:54 +0100	[thread overview]
Message-ID: <20070619190454.GB3830@infradead.org> (raw)
In-Reply-To: <4678013C.5090402@grupopie.com>

On Tue, Jun 19, 2007 at 05:15:56PM +0100, Paulo Marques wrote:
> 
> The only in-kernel user of "memmem" is scripts/kallsyms.c and it only 
> uses it to find tokens that are 2 bytes in size. It is trivial to 
> replace it with a simple function that finds 2-byte tokens.
> 
> This should help users from systems that don't have the memmem GNU 
> extension available.

Please add a comment describing why it's there so that it's not ripped
out again by the first janitor looking over the code.


  parent reply	other threads:[~2007-06-19 19:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-19 16:15 [PATCH] remove usage of memmem from scripts/kallsyms.c Paulo Marques
2007-06-19 17:43 ` Mike Frysinger
2007-06-19 18:47 ` Satyam Sharma
2007-06-20  4:33   ` Mike Frysinger
2007-06-20 11:56     ` Paulo Marques
2007-06-20 15:25       ` Segher Boessenkool
2007-06-20 15:53         ` Paulo Marques
2007-06-20 16:42           ` Sam Ravnborg
2007-06-19 19:04 ` Christoph Hellwig [this message]
2007-06-20 11:53   ` Paulo Marques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070619190454.GB3830@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmarques@grupopie.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.