From: Segher Boessenkool <segher@kernel.crashing.org>
To: Paulo Marques <pmarques@grupopie.com>
Cc: Mike Frysinger <vapier@gentoo.org>,
Satyam Sharma <satyam.sharma@gmail.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] remove usage of memmem from scripts/kallsyms.c
Date: Wed, 20 Jun 2007 17:25:37 +0200 [thread overview]
Message-ID: <c8d2863984d16e31de2aaed038b7367a@kernel.crashing.org> (raw)
In-Reply-To: <467915DD.7020906@grupopie.com>
>>> So we could remove the "#define _GNU_SOURCE" at the top
>>> of scripts/kallsyms.c too, presumably? If not (i.e. if there are
>>> more GNUisms left in that file anyway), then I'm not sure if we
>>> really gain by the change.
>> yes, i believe this is true
>
> I only tried in on x86 with my toolchain and it works, but I don't
> know if it is worth the risk of breaking someone's setup for virtually
> no gain...
With the memmem() removed, the code builds (and works)
fine on several non-GNU systems. It should be perfectly
safe to remove the _GNU_SOURCE. Perhaps you should
replace it with the proper POSIX_ define so it won't
be broken again?
Segher
next prev parent reply other threads:[~2007-06-20 15:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 16:15 [PATCH] remove usage of memmem from scripts/kallsyms.c Paulo Marques
2007-06-19 17:43 ` Mike Frysinger
2007-06-19 18:47 ` Satyam Sharma
2007-06-20 4:33 ` Mike Frysinger
2007-06-20 11:56 ` Paulo Marques
2007-06-20 15:25 ` Segher Boessenkool [this message]
2007-06-20 15:53 ` Paulo Marques
2007-06-20 16:42 ` Sam Ravnborg
2007-06-19 19:04 ` Christoph Hellwig
2007-06-20 11:53 ` Paulo Marques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8d2863984d16e31de2aaed038b7367a@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmarques@grupopie.com \
--cc=satyam.sharma@gmail.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.